Skip to content

Commit ecaced5

Browse files
authored
Node Frame - Simplify Caching (#31896)
* simplify nodeFrame * fix comment spacing
1 parent aa3e118 commit ecaced5

File tree

1 file changed

+20
-20
lines changed

1 file changed

+20
-20
lines changed

src/nodes/core/NodeFrame.js

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -124,8 +124,8 @@ class NodeFrame {
124124
if ( maps === undefined ) {
125125

126126
maps = {
127-
renderMap: new WeakMap(),
128-
frameMap: new WeakMap()
127+
renderId: 0,
128+
frameId: 0,
129129
};
130130

131131
referenceMap.set( nodeRef, maps );
@@ -151,27 +151,27 @@ class NodeFrame {
151151

152152
if ( updateType === NodeUpdateType.FRAME ) {
153153

154-
const { frameMap } = this._getMaps( this.updateBeforeMap, reference );
154+
const nodeUpdateBeforeMap = this._getMaps( this.updateBeforeMap, reference );
155155

156-
if ( frameMap.get( reference ) !== this.frameId ) {
156+
if ( nodeUpdateBeforeMap.frameId !== this.frameId ) {
157157

158158
if ( node.updateBefore( this ) !== false ) {
159159

160-
frameMap.set( reference, this.frameId );
160+
nodeUpdateBeforeMap.frameId = this.frameId;
161161

162162
}
163163

164164
}
165165

166166
} else if ( updateType === NodeUpdateType.RENDER ) {
167167

168-
const { renderMap } = this._getMaps( this.updateBeforeMap, reference );
168+
const nodeUpdateBeforeMap = this._getMaps( this.updateBeforeMap, reference );
169169

170-
if ( renderMap.get( reference ) !== this.renderId ) {
170+
if ( nodeUpdateBeforeMap.renderId !== this.renderId ) {
171171

172172
if ( node.updateBefore( this ) !== false ) {
173173

174-
renderMap.set( reference, this.renderId );
174+
nodeUpdateBeforeMap.renderId = this.renderId;
175175

176176
}
177177

@@ -200,27 +200,27 @@ class NodeFrame {
200200

201201
if ( updateType === NodeUpdateType.FRAME ) {
202202

203-
const { frameMap } = this._getMaps( this.updateAfterMap, reference );
203+
const nodeUpdateAfterMap = this._getMaps( this.updateAfterMap, reference );
204204

205-
if ( frameMap.get( reference ) !== this.frameId ) {
205+
if ( nodeUpdateAfterMap.frameId !== this.frameId ) {
206206

207207
if ( node.updateAfter( this ) !== false ) {
208208

209-
frameMap.set( reference, this.frameId );
209+
nodeUpdateAfterMap.frameId = this.frameId;
210210

211211
}
212212

213213
}
214214

215215
} else if ( updateType === NodeUpdateType.RENDER ) {
216216

217-
const { renderMap } = this._getMaps( this.updateAfterMap, reference );
217+
const nodeUpdateAfterMap = this._getMaps( this.updateAfterMap, reference );
218218

219-
if ( renderMap.get( reference ) !== this.renderId ) {
219+
if ( nodeUpdateAfterMap.renderId !== this.renderId ) {
220220

221221
if ( node.updateAfter( this ) !== false ) {
222222

223-
renderMap.set( reference, this.renderId );
223+
nodeUpdateAfterMap.renderId = this.renderId;
224224

225225
}
226226

@@ -249,27 +249,27 @@ class NodeFrame {
249249

250250
if ( updateType === NodeUpdateType.FRAME ) {
251251

252-
const { frameMap } = this._getMaps( this.updateMap, reference );
252+
const nodeUpdateMap = this._getMaps( this.updateMap, reference );
253253

254-
if ( frameMap.get( reference ) !== this.frameId ) {
254+
if ( nodeUpdateMap.frameId !== this.frameId ) {
255255

256256
if ( node.update( this ) !== false ) {
257257

258-
frameMap.set( reference, this.frameId );
258+
nodeUpdateMap.frameId = this.frameId;
259259

260260
}
261261

262262
}
263263

264264
} else if ( updateType === NodeUpdateType.RENDER ) {
265265

266-
const { renderMap } = this._getMaps( this.updateMap, reference );
266+
const nodeUpdateMap = this._getMaps( this.updateMap, reference );
267267

268-
if ( renderMap.get( reference ) !== this.renderId ) {
268+
if ( nodeUpdateMap.renderId !== this.renderId ) {
269269

270270
if ( node.update( this ) !== false ) {
271271

272-
renderMap.set( reference, this.renderId );
272+
nodeUpdateMap.renderId = this.renderId;
273273

274274
}
275275

0 commit comments

Comments
 (0)