Skip to content

Commit eab03f0

Browse files
authored
Merge pull request #14279 from WestLangley/dev-fat_line_fix
Fix for fat line pixelation artifacts
2 parents 6c625ea + 5404425 commit eab03f0

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

examples/js/lines/LineMaterial.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -205,19 +205,19 @@ THREE.ShaderLib[ 'line' ] = {
205205
206206
#ifdef USE_DASH
207207
208-
if ( vUv.y < 0.5 || vUv.y > 0.5 ) discard; // discard endcaps
208+
if ( vUv.y < - 1.0 || vUv.y > 1.0 ) discard; // discard endcaps
209209
210210
if ( mod( vLineDistance, dashSize + gapSize ) > dashSize ) discard; // todo - FIX
211211
212212
#endif
213213
214-
if ( vUv.y < 0.5 || vUv.y > 0.5 ) {
214+
if ( abs( vUv.y ) > 1.0 ) {
215215
216-
float a = vUv.x - 0.5;
217-
float b = vUv.y - 0.5;
216+
float a = vUv.x;
217+
float b = ( vUv.y > 0.0 ) ? vUv.y - 1.0 : vUv.y + 1.0;
218218
float len2 = a * a + b * b;
219219
220-
if ( len2 > 0.25 ) discard;
220+
if ( len2 > 1.0 ) discard;
221221
222222
}
223223

examples/js/lines/LineSegmentsGeometry.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ THREE.LineSegmentsGeometry = function () {
1212
var plane = new THREE.BufferGeometry();
1313

1414
var positions = [ - 1, 2, 0, 1, 2, 0, - 1, 1, 0, 1, 1, 0, - 1, 0, 0, 1, 0, 0, - 1, - 1, 0, 1, - 1, 0 ];
15-
var uvs = [ 0, 1, 1, 1, 0, .5, 1, .5, 0, .5, 1, .5, 0, 0, 1, 0 ];
15+
var uvs = [ - 1, 2, 1, 2, - 1, 1, 1, 1, - 1, - 1, 1, - 1, - 1, - 2, 1, - 2 ];
1616
var index = [ 0, 2, 1, 2, 3, 1, 2, 4, 3, 4, 5, 3, 4, 6, 5, 6, 7, 5 ];
1717

1818
this.setIndex( index );

0 commit comments

Comments
 (0)