Skip to content

Commit e78b8cf

Browse files
mrdoobmrdoob
committed
Fixed some LGTM alerts.
1 parent 755d929 commit e78b8cf

7 files changed

+41
-43
lines changed

‎examples/canvas_lines_colors.html‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@
7979
// 2d lines
8080

8181
var vertices = hilbert2D( new THREE.Vector3( 0, 0, 0 ), 400, 4 );
82-
numVertices = vertices.length;
82+
var numVertices = vertices.length;
8383

8484
var geometry2 = new THREE.BufferGeometry();
8585

@@ -108,7 +108,7 @@
108108
// 3d lines
109109

110110
var vertices = hilbert3D( new THREE.Vector3( 0, 0, 0 ), 200, 2, 0, 1, 2, 3, 4, 5, 6, 7 );
111-
numVertices = vertices.length;
111+
var numVertices = vertices.length;
112112

113113
var geometry3 = new THREE.BufferGeometry();
114114

‎examples/canvas_lines_dashed.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@
6565
var spline = new THREE.CatmullRomCurve3( points );
6666

6767
var samples = spline.getPoints( points.length * subdivisions );
68-
numSamples = samples.length;
68+
var numSamples = samples.length;
6969

7070
var geometrySpline = new THREE.BufferGeometry();
7171

‎examples/webgl_geometry_colors.html‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -115,8 +115,8 @@
115115
var count = geometry1.attributes.position.count;
116116
geometry1.addAttribute( 'color', new THREE.BufferAttribute( new Float32Array( count * 3 ), 3 ) );
117117

118-
geometry2 = geometry1.clone();
119-
geometry3 = geometry1.clone();
118+
var geometry2 = geometry1.clone();
119+
var geometry3 = geometry1.clone();
120120

121121
var color = new THREE.Color();
122122
var positions1 = geometry1.attributes.position;
@@ -148,21 +148,21 @@
148148

149149
var wireframeMaterial = new THREE.MeshBasicMaterial( { color: 0x000000, wireframe: true, transparent: true } );
150150

151-
mesh = new THREE.Mesh( geometry1, material );
152-
wireframe = new THREE.Mesh( geometry1, wireframeMaterial );
151+
var mesh = new THREE.Mesh( geometry1, material );
152+
var wireframe = new THREE.Mesh( geometry1, wireframeMaterial );
153153
mesh.add( wireframe );
154154
mesh.position.x = - 400;
155155
mesh.rotation.x = - 1.87;
156156
scene.add( mesh );
157157

158-
mesh = new THREE.Mesh( geometry2, material );
159-
wireframe = new THREE.Mesh( geometry2, wireframeMaterial );
158+
var mesh = new THREE.Mesh( geometry2, material );
159+
var wireframe = new THREE.Mesh( geometry2, wireframeMaterial );
160160
mesh.add( wireframe );
161161
mesh.position.x = 400;
162162
scene.add( mesh );
163163

164-
mesh = new THREE.Mesh( geometry3, material );
165-
wireframe = new THREE.Mesh( geometry3, wireframeMaterial );
164+
var mesh = new THREE.Mesh( geometry3, material );
165+
var wireframe = new THREE.Mesh( geometry3, wireframeMaterial );
166166
mesh.add( wireframe );
167167
scene.add( mesh );
168168

‎examples/webgl_multiple_canvases_complex.html‎

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -177,8 +177,8 @@
177177
var count = geometry1.attributes.position.count;
178178
geometry1.addAttribute( 'color', new THREE.BufferAttribute( new Float32Array( count * 3 ), 3 ) );
179179

180-
geometry2 = geometry1.clone();
181-
geometry3 = geometry1.clone();
180+
var geometry2 = geometry1.clone();
181+
var geometry3 = geometry1.clone();
182182

183183
var color = new THREE.Color();
184184
var positions1 = geometry1.attributes.position;
@@ -210,23 +210,21 @@
210210

211211
var wireframeMaterial = new THREE.MeshBasicMaterial( { color: 0x000000, wireframe: true, transparent: true } );
212212

213-
var mesh, wireframe;
214-
215-
mesh = new THREE.Mesh( geometry1, material );
216-
wireframe = new THREE.Mesh( geometry1, wireframeMaterial );
213+
var mesh = new THREE.Mesh( geometry1, material );
214+
var wireframe = new THREE.Mesh( geometry1, wireframeMaterial );
217215
mesh.add( wireframe );
218216
mesh.position.x = - 400;
219217
mesh.rotation.x = - 1.87;
220218
scene.add( mesh );
221219

222-
mesh = new THREE.Mesh( geometry2, material );
223-
wireframe = new THREE.Mesh( geometry2, wireframeMaterial );
220+
var mesh = new THREE.Mesh( geometry2, material );
221+
var wireframe = new THREE.Mesh( geometry2, wireframeMaterial );
224222
mesh.add( wireframe );
225223
mesh.position.x = 400;
226224
scene.add( mesh );
227225

228-
mesh = new THREE.Mesh( geometry3, material );
229-
wireframe = new THREE.Mesh( geometry3, wireframeMaterial );
226+
var mesh = new THREE.Mesh( geometry3, material );
227+
var wireframe = new THREE.Mesh( geometry3, wireframeMaterial );
230228
mesh.add( wireframe );
231229
scene.add( mesh );
232230

‎examples/webgl_multiple_canvases_grid.html‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -195,8 +195,8 @@
195195
var count = geometry1.attributes.position.count;
196196
geometry1.addAttribute( 'color', new THREE.BufferAttribute( new Float32Array( count * 3 ), 3 ) );
197197

198-
geometry2 = geometry1.clone();
199-
geometry3 = geometry1.clone();
198+
var geometry2 = geometry1.clone();
199+
var geometry3 = geometry1.clone();
200200

201201
var color = new THREE.Color();
202202
var positions1 = geometry1.attributes.position;
@@ -228,21 +228,21 @@
228228

229229
var wireframeMaterial = new THREE.MeshBasicMaterial( { color: 0x000000, wireframe: true, transparent: true } );
230230

231-
mesh = new THREE.Mesh( geometry1, material );
232-
wireframe = new THREE.Mesh( geometry1, wireframeMaterial );
231+
var mesh = new THREE.Mesh( geometry1, material );
232+
var wireframe = new THREE.Mesh( geometry1, wireframeMaterial );
233233
mesh.add( wireframe );
234234
mesh.position.x = - 400;
235235
mesh.rotation.x = - 1.87;
236236
scene.add( mesh );
237237

238-
mesh = new THREE.Mesh( geometry2, material );
239-
wireframe = new THREE.Mesh( geometry2, wireframeMaterial );
238+
var mesh = new THREE.Mesh( geometry2, material );
239+
var wireframe = new THREE.Mesh( geometry2, wireframeMaterial );
240240
mesh.add( wireframe );
241241
mesh.position.x = 400;
242242
scene.add( mesh );
243243

244-
mesh = new THREE.Mesh( geometry3, material );
245-
wireframe = new THREE.Mesh( geometry3, wireframeMaterial );
244+
var mesh = new THREE.Mesh( geometry3, material );
245+
var wireframe = new THREE.Mesh( geometry3, wireframeMaterial );
246246
mesh.add( wireframe );
247247
scene.add( mesh );
248248

‎examples/webgl_multiple_renderers.html‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -142,21 +142,21 @@
142142

143143
var wireframeMaterial = new THREE.MeshBasicMaterial( { color: 0x000000, wireframe: true, transparent: true } );
144144

145-
mesh1 = new THREE.Mesh( geometry1, material );
146-
wireframe = new THREE.Mesh( geometry1, wireframeMaterial );
145+
var mesh1 = new THREE.Mesh( geometry1, material );
146+
var wireframe = new THREE.Mesh( geometry1, wireframeMaterial );
147147
mesh1.add( wireframe );
148148
mesh1.position.x = - 400;
149149
mesh1.rotation.x = - 1.87;
150150
scene.add( mesh1 );
151151

152-
mesh2 = new THREE.Mesh( geometry2, material );
153-
wireframe = new THREE.Mesh( geometry2, wireframeMaterial );
152+
var mesh2 = new THREE.Mesh( geometry2, material );
153+
var wireframe = new THREE.Mesh( geometry2, wireframeMaterial );
154154
mesh2.add( wireframe );
155155
mesh2.position.x = 400;
156156
scene.add( mesh2 );
157157

158-
mesh3 = new THREE.Mesh( geometry3, material );
159-
wireframe = new THREE.Mesh( geometry3, wireframeMaterial );
158+
var mesh3 = new THREE.Mesh( geometry3, material );
159+
var wireframe = new THREE.Mesh( geometry3, wireframeMaterial );
160160
mesh3.add( wireframe );
161161
scene.add( mesh3 );
162162

‎examples/webgl_multiple_views.html‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -166,8 +166,8 @@
166166
var count = geometry1.attributes.position.count;
167167
geometry1.addAttribute( 'color', new THREE.BufferAttribute( new Float32Array( count * 3 ), 3 ) );
168168

169-
geometry2 = geometry1.clone();
170-
geometry3 = geometry1.clone();
169+
var geometry2 = geometry1.clone();
170+
var geometry3 = geometry1.clone();
171171

172172
var color = new THREE.Color();
173173
var positions1 = geometry1.attributes.position;
@@ -199,21 +199,21 @@
199199

200200
var wireframeMaterial = new THREE.MeshBasicMaterial( { color: 0x000000, wireframe: true, transparent: true } );
201201

202-
mesh = new THREE.Mesh( geometry1, material );
203-
wireframe = new THREE.Mesh( geometry1, wireframeMaterial );
202+
var mesh = new THREE.Mesh( geometry1, material );
203+
var wireframe = new THREE.Mesh( geometry1, wireframeMaterial );
204204
mesh.add( wireframe );
205205
mesh.position.x = - 400;
206206
mesh.rotation.x = - 1.87;
207207
scene.add( mesh );
208208

209-
mesh = new THREE.Mesh( geometry2, material );
210-
wireframe = new THREE.Mesh( geometry2, wireframeMaterial );
209+
var mesh = new THREE.Mesh( geometry2, material );
210+
var wireframe = new THREE.Mesh( geometry2, wireframeMaterial );
211211
mesh.add( wireframe );
212212
mesh.position.x = 400;
213213
scene.add( mesh );
214214

215-
mesh = new THREE.Mesh( geometry3, material );
216-
wireframe = new THREE.Mesh( geometry3, wireframeMaterial );
215+
var mesh = new THREE.Mesh( geometry3, material );
216+
var wireframe = new THREE.Mesh( geometry3, wireframeMaterial );
217217
mesh.add( wireframe );
218218
scene.add( mesh );
219219

0 commit comments

Comments
 (0)