Merge pull request #16435 from but0n/gltfloader-fix

mrdoob · web-flow · commit e224a6c75689 · 2019-05-21T20:54:57.000-07:00
fix cloneMaterial: incase texture is null
diff --git a/examples/js/loaders/GLTFLoader.js b/examples/js/loaders/GLTFLoader.js
@@ -842,7 +842,7 @@ THREE.GLTFLoader = ( function () {
 				for ( var i = 0, il = params.length; i < il; i ++ ) {
 
 					var value = source[ params[ i ] ];
-					target[ params[ i ] ] = value.isColor ? value.clone() : value;
+					target[ params[ i ] ] = ( value && value.isColor ) ? value.clone() : value;
 
 				}
 

Original file line number	Diff line number	Diff line change
`@@ -842,7 +842,7 @@ THREE.GLTFLoader = ( function () {`
`842`	`842`	`for ( var i = 0, il = params.length; i < il; i ++ ) {`
`843`	`843`
`844`	`844`	`var value = source[ params[ i ] ];`
`845`		`- target[ params[ i ] ] = value.isColor ? value.clone() : value;`
	`845`	`+ target[ params[ i ] ] = ( value && value.isColor ) ? value.clone() : value;`
`846`	`846`
`847`	`847`	`}`
`848`	`848`