Skip to content

Commit dc7af39

Browse files
committed
WebGLState: Removed setColor*/setDepth*/setStencil* methods.
1 parent 46cb30b commit dc7af39

File tree

5 files changed

+15
-73
lines changed

5 files changed

+15
-73
lines changed

src/renderers/WebGLRenderer.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1278,9 +1278,9 @@ function WebGLRenderer( parameters ) {
12781278

12791279
// Ensure depth buffer writing is enabled so it can be cleared on next render
12801280

1281-
state.setDepthTest( true );
1282-
state.setDepthWrite( true );
1283-
state.setColorWrite( true );
1281+
state.buffers.depth.setTest( true );
1282+
state.buffers.depth.setMask( true );
1283+
state.buffers.color.setMask( true );
12841284

12851285
// _gl.finish();
12861286

src/renderers/webgl/WebGLShadowMap.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,9 +109,9 @@ function WebGLShadowMap( _renderer, _lights, _objects, capabilities ) {
109109
if ( _lightShadows.length === 0 ) return;
110110

111111
// Set GL state for depth map.
112-
_state.buffers.color.setClear( 1, 1, 1, 1 );
113112
_state.disable( _gl.BLEND );
114-
_state.setDepthTest( true );
113+
_state.buffers.color.setClear( 1, 1, 1, 1 );
114+
_state.buffers.depth.setTest( true );
115115
_state.setScissorTest( false );
116116

117117
// render depth map

src/renderers/webgl/WebGLState.js

Lines changed: 6 additions & 64 deletions
Original file line numberDiff line numberDiff line change
@@ -383,7 +383,7 @@ function WebGLState( gl, extensions, paramThreeToGL ) {
383383
stencilBuffer.setClear( 0 );
384384

385385
enable( gl.DEPTH_TEST );
386-
setDepthFunc( LessEqualDepth );
386+
depthBuffer.setFunc( LessEqualDepth );
387387

388388
setFlipSided( false );
389389
setCullFace( CullFaceBack );
@@ -637,61 +637,12 @@ function WebGLState( gl, extensions, paramThreeToGL ) {
637637
? setBlending( material.blending, material.blendEquation, material.blendSrc, material.blendDst, material.blendEquationAlpha, material.blendSrcAlpha, material.blendDstAlpha, material.premultipliedAlpha )
638638
: setBlending( NoBlending );
639639

640-
setDepthFunc( material.depthFunc );
641-
setDepthTest( material.depthTest );
642-
setDepthWrite( material.depthWrite );
643-
setColorWrite( material.colorWrite );
644-
setPolygonOffset( material.polygonOffset, material.polygonOffsetFactor, material.polygonOffsetUnits );
645-
646-
}
647-
648-
// TODO Deprecate
649-
650-
function setColorWrite( colorWrite ) {
651-
652-
colorBuffer.setMask( colorWrite );
653-
654-
}
655-
656-
function setDepthTest( depthTest ) {
657-
658-
depthBuffer.setTest( depthTest );
659-
660-
}
661-
662-
function setDepthWrite( depthWrite ) {
663-
664-
depthBuffer.setMask( depthWrite );
665-
666-
}
667-
668-
function setDepthFunc( depthFunc ) {
669-
670-
depthBuffer.setFunc( depthFunc );
640+
depthBuffer.setFunc( material.depthFunc );
641+
depthBuffer.setTest( material.depthTest );
642+
depthBuffer.setMask( material.depthWrite );
643+
colorBuffer.setMask( material.colorWrite );
671644

672-
}
673-
674-
function setStencilTest( stencilTest ) {
675-
676-
stencilBuffer.setTest( stencilTest );
677-
678-
}
679-
680-
function setStencilWrite( stencilWrite ) {
681-
682-
stencilBuffer.setMask( stencilWrite );
683-
684-
}
685-
686-
function setStencilFunc( stencilFunc, stencilRef, stencilMask ) {
687-
688-
stencilBuffer.setFunc( stencilFunc, stencilRef, stencilMask );
689-
690-
}
691-
692-
function setStencilOp( stencilFail, stencilZFail, stencilZPass ) {
693-
694-
stencilBuffer.setOp( stencilFail, stencilZFail, stencilZPass );
645+
setPolygonOffset( material.polygonOffset, material.polygonOffsetFactor, material.polygonOffsetUnits );
695646

696647
}
697648

@@ -956,15 +907,6 @@ function WebGLState( gl, extensions, paramThreeToGL ) {
956907
setBlending: setBlending,
957908
setMaterial: setMaterial,
958909

959-
setColorWrite: setColorWrite,
960-
setDepthTest: setDepthTest,
961-
setDepthWrite: setDepthWrite,
962-
setDepthFunc: setDepthFunc,
963-
setStencilTest: setStencilTest,
964-
setStencilWrite: setStencilWrite,
965-
setStencilFunc: setStencilFunc,
966-
setStencilOp: setStencilOp,
967-
968910
setFlipSided: setFlipSided,
969911
setCullFace: setCullFace,
970912

src/renderers/webgl/plugins/LensFlarePlugin.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ function LensFlarePlugin( renderer, flares ) {
228228
gl.bindBuffer( gl.ELEMENT_ARRAY_BUFFER, elementBuffer );
229229

230230
state.disable( gl.CULL_FACE );
231-
state.setDepthWrite( false );
231+
state.buffers.depth.setMask( false );
232232

233233
for ( var i = 0, l = flares.length; i < l; i ++ ) {
234234

@@ -353,7 +353,7 @@ function LensFlarePlugin( renderer, flares ) {
353353

354354
state.enable( gl.CULL_FACE );
355355
state.enable( gl.DEPTH_TEST );
356-
state.setDepthWrite( true );
356+
state.buffers.depth.setMask( true );
357357

358358
renderer.resetGLState();
359359

src/renderers/webgl/plugins/SpritePlugin.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -224,8 +224,8 @@ function SpritePlugin( renderer, sprites ) {
224224
gl.uniform2fv( uniforms.scale, scale );
225225

226226
state.setBlending( material.blending, material.blendEquation, material.blendSrc, material.blendDst );
227-
state.setDepthTest( material.depthTest );
228-
state.setDepthWrite( material.depthWrite );
227+
state.buffers.depth.setTest( material.depthTest );
228+
state.buffers.depth.setMask( material.depthWrite );
229229

230230
if ( material.map ) {
231231

0 commit comments

Comments
 (0)