Renderer: Manage PMREMGenerato in renderer instead of node builder.

Author: Mugen87

src/nodes/core/NodeBuilder.js

@@ -22,8 +22,6 @@ import { getCurrentStack, setCurrentStack } from '../tsl/TSLBase.js';
 import CubeRenderTarget from '../../renderers/common/CubeRenderTarget.js';
 import ChainMap from '../../renderers/common/ChainMap.js';
 
-import PMREMGenerator from '../../renderers/common/extras/PMREMGenerator.js';
-
 import BindGroup from '../../renderers/common/BindGroup.js';
 
 import { REVISION, IntType, UnsignedIntType, LinearFilter, LinearMipmapNearestFilter, NearestMipmapLinearFilter, LinearMipmapLinearFilter } from '../../constants.js';
@@ -472,19 +470,6 @@ class NodeBuilder {
 
 	}
 
-	/**
-	 * Factory method for creating an instance of {@link PMREMGenerator}.
-	 *
-	 * @return {PMREMGenerator} The PMREM generator.
-	 */
-	createPMREMGenerator() {
-
-		// TODO: Move Materials.js to outside of the Nodes.js in order to remove this function and improve tree-shaking support
-
-		return new PMREMGenerator( this.renderer );
-
-	}
-
 	/**
 	 * Whether the given node is included in the internal array of nodes or not.
 	 *

src/nodes/pmrem/PMREMNode.js

@@ -8,8 +8,6 @@ import { nodeProxy, vec3 } from '../tsl/TSLBase.js';
 import { WebGLCoordinateSystem } from '../../constants.js';
 import { Texture } from '../../textures/Texture.js';
 
-let _generator = null;
-
 const _cache = new WeakMap();
 
 /**
@@ -36,9 +34,10 @@ function _generateCubeUVSize( imageHeight ) {
  *
  * @private
  * @param {Texture} texture - The texture to create the PMREM for.
+ * @param {PMREMGenerator} generator - The PMREM generator.
  * @return {Texture} The PMREM.
  */
-function _getPMREMFromTexture( texture ) {
+function _getPMREMFromTexture( texture, generator ) {
 
 	let cacheTexture = _cache.get( texture );
 
@@ -52,7 +51,7 @@ function _getPMREMFromTexture( texture ) {
 
 			if ( isCubeMapReady( image ) ) {
 
-				cacheTexture = _generator.fromCubemap( texture, cacheTexture );
+				cacheTexture = generator.fromCubemap( texture, cacheTexture );
 
 			} else {
 
@@ -65,7 +64,7 @@ function _getPMREMFromTexture( texture ) {
 
 			if ( isEquirectangularMapReady( image ) ) {
 
-				cacheTexture = _generator.fromEquirectangular( texture, cacheTexture );
+				cacheTexture = generator.fromEquirectangular( texture, cacheTexture );
 
 			} else {
 
@@ -234,7 +233,7 @@ class PMREMNode extends TempNode {
 
 	}
 
-	updateBefore() {
+	updateBefore( frame ) {
 
 		let pmrem = this._pmrem;
 
@@ -249,7 +248,7 @@ class PMREMNode extends TempNode {
 
 			} else {
 
-				pmrem = _getPMREMFromTexture( texture );
+				pmrem = _getPMREMFromTexture( texture, frame.builder.renderer._getPMREMGenerator() );
 
 			}
 
@@ -267,15 +266,7 @@ class PMREMNode extends TempNode {
 
 	setup( builder ) {
 
-		if ( _generator === null ) {
-
-			_generator = builder.createPMREMGenerator();
-
-		}
-
-		//
-
-		this.updateBefore( builder );
+		this.updateBefore( { builder } );
 
 		//
 

src/renderers/common/Renderer.js

@@ -17,6 +17,7 @@ import RenderBundles from './RenderBundles.js';
 import NodeLibrary from './nodes/NodeLibrary.js';
 import Lighting from './Lighting.js';
 import XRManager from './XRManager.js';
+import PMREMGenerator from './extras/PMREMGenerator.js';
 
 import NodeMaterial from '../../materials/nodes/NodeMaterial.js';
 
@@ -625,6 +626,14 @@ class Renderer {
 		 */
 		this._compilationPromises = null;
 
+		/**
+		 * A reference to a PMREM generator that can be globally used for generating PMREMs.
+		 *
+		 * @type {?PMREMGenerator}
+		 * @default null
+		 */
+		this._pmremGenerator = null;
+
 		/**
 		 * Whether the renderer should render transparent render objects or not.
 		 *
@@ -2080,6 +2089,8 @@ class Renderer {
 		this._renderContexts.dispose();
 		this._textures.dispose();
 
+		if ( this._pmremGenerator !== null ) this._pmremGenerator.dispose();
+
 		if ( this._frameBufferTarget !== null ) this._frameBufferTarget.dispose();
 
 		Object.values( this.backend.timestampQueryPool ).forEach( queryPool => {
@@ -2910,6 +2921,24 @@ class Renderer {
 
 	}
 
+	/**
+	 * Returns an instance of {@link PMREMGenerator} for PMREM generation.
+	 *
+	 * @private
+	 * @return {PMREMGenerator} The PMREM generator.
+	 */
+	_getPMREMGenerator() {
+
+		if ( this._pmremGenerator === null ) {
+
+			this._pmremGenerator = new PMREMGenerator( this );
+
+		}
+
+		return this._pmremGenerator;
+
+	}
+
 	/**
 	 * Alias for `compileAsync()`.
 	 *