Skip to content

Commit c793e60

Browse files
authored
Remove modularize script (#21587)
1 parent 157fd1c commit c793e60

File tree

2 files changed

+7
-342
lines changed

2 files changed

+7
-342
lines changed

.github/CONTRIBUTING.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,15 @@ It is assumed that you know a little about node.js and git. If not, [here's some
55

66
* Install [Node.js](https://nodejs.org/)
77
* Install [Git](https://git-scm.com/)
8-
* [Fork](https://help.github.com/en/github/getting-started-with-github/fork-a-repo) three.js
8+
* [Fork](https://help.github.com/en/github/getting-started-with-github/fork-a-repo) three.js
99
* Open your OS’s terminal
1010
* Change into the directory you’d like
1111
* Clone your forked repo
1212

1313
git clone https://github.com/[yourgithubname]/three.js.git
1414

1515
* Go into the three.js directory.
16-
16+
1717
cd ./three.js
1818

1919
* Install the dependencies
@@ -39,20 +39,20 @@ Many linting errors can be fixed automatically by running
3939
npm lint-fix
4040

4141
If you’d like to make a minified version of the build files i.e. ‘build/three.min.js’ run:
42-
42+
4343
npm run build
4444

4545
## Making changes
4646

4747
When you’ve decided to make changes, start with the following:
4848

4949
* Update your local repo
50-
50+
5151
git pull https://github.com/mrdoob/three.js.git
5252
git push
5353

5454
* Make a new branch from the dev branch
55-
55+
5656
git checkout dev
5757
git branch [mychangesbranch]
5858
git checkout [mychangesbranch]
@@ -70,8 +70,8 @@ When you’ve decided to make changes, start with the following:
7070
* If you modify existing code, run relevant examples to check they didn't break and there wasn't performance regress.
7171
* If you add some assets for the examples (models, textures, sounds, etc), make sure they have a proper license allowing for their use here, less restrictive the better. It is unlikely for large assets to be accepted.
7272
* If some issue is relevant to patch / feature, please mention it with hash (e.g. #2774) in a commit message to get cross-reference in GitHub.
73-
* If you modify files in `examples/js` directory, then don't perform any changes in the `examples/jsm`, JavaScript modules are auto-generated via running `node utils/modularize.js`.
74-
* If end-to-end test failed in Travis and you are sure that all is correct, make a new screenshots with
73+
* If you modify files in `examples/jsm` directory, then don't perform any changes in the `examples/js`, non-module files are auto-generated by running `npm run build-examples`.
74+
* If end-to-end test failed in Travis and you are sure that all is correct, make a new screenshots with
7575

7676
npm run make-screenshot <example_1_name> ...<example_N_name>
7777

0 commit comments

Comments
 (0)