You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@@ -70,8 +70,8 @@ When you’ve decided to make changes, start with the following:
70
70
* If you modify existing code, run relevant examples to check they didn't break and there wasn't performance regress.
71
71
* If you add some assets for the examples (models, textures, sounds, etc), make sure they have a proper license allowing for their use here, less restrictive the better. It is unlikely for large assets to be accepted.
72
72
* If some issue is relevant to patch / feature, please mention it with hash (e.g. #2774) in a commit message to get cross-reference in GitHub.
73
-
* If you modify files in `examples/js` directory, then don't perform any changes in the `examples/jsm`, JavaScript modules are auto-generated via running `node utils/modularize.js`.
74
-
* If end-to-end test failed in Travis and you are sure that all is correct, make a new screenshots with
73
+
* If you modify files in `examples/jsm` directory, then don't perform any changes in the `examples/js`, non-module files are auto-generated by running `npm run build-examples`.
74
+
* If end-to-end test failed in Travis and you are sure that all is correct, make a new screenshots with
75
75
76
76
npm run make-screenshot <example_1_name> ...<example_N_name>
0 commit comments