Skip to content

Commit c5ea12e

Browse files
authored
Merge pull request #14319 from Mugen87/dev12
SubdivisionModifier: Honor material indices
2 parents ba381af + 0e1af8c commit c5ea12e

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

examples/js/modifiers/SubdivisionModifier.js

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ THREE.SubdivisionModifier.prototype.modify = function ( geometry ) {
3636

3737
};
3838

39-
( function() {
39+
( function () {
4040

4141
// Some constants
4242
var WARNINGS = ! true; // Set to true for development
@@ -98,7 +98,7 @@ THREE.SubdivisionModifier.prototype.modify = function ( geometry ) {
9898

9999
function generateLookups( vertices, faces, metaVertices, edges ) {
100100

101-
var i, il, face, edge;
101+
var i, il, face;
102102

103103
for ( i = 0, il = vertices.length; i < il; i ++ ) {
104104

@@ -118,9 +118,9 @@ THREE.SubdivisionModifier.prototype.modify = function ( geometry ) {
118118

119119
}
120120

121-
function newFace( newFaces, a, b, c ) {
121+
function newFace( newFaces, a, b, c, materialIndex ) {
122122

123-
newFaces.push( new THREE.Face3( a, b, c ) );
123+
newFaces.push( new THREE.Face3( a, b, c, undefined, undefined, materialIndex ) );
124124

125125
}
126126

@@ -146,7 +146,7 @@ THREE.SubdivisionModifier.prototype.modify = function ( geometry ) {
146146
var oldVertices, oldFaces, oldUvs;
147147
var newVertices, newFaces, newUVs = [];
148148

149-
var n, l, i, il, j, k;
149+
var n, i, il, j, k;
150150
var metaVertices, sourceEdges;
151151

152152
// new stuff.
@@ -346,10 +346,10 @@ THREE.SubdivisionModifier.prototype.modify = function ( geometry ) {
346346

347347
// create 4 faces.
348348

349-
newFace( newFaces, edge1, edge2, edge3 );
350-
newFace( newFaces, face.a, edge1, edge3 );
351-
newFace( newFaces, face.b, edge2, edge1 );
352-
newFace( newFaces, face.c, edge3, edge2 );
349+
newFace( newFaces, edge1, edge2, edge3, face.materialIndex );
350+
newFace( newFaces, face.a, edge1, edge3, face.materialIndex );
351+
newFace( newFaces, face.b, edge2, edge1, face.materialIndex );
352+
newFace( newFaces, face.c, edge3, edge2, face.materialIndex );
353353

354354
// create 4 new uv's
355355

0 commit comments

Comments
 (0)