Skip to content

Commit c36f35d

Browse files
authored
Merge pull request #13822 from Mugen87/dev4
Examples: More clean up
2 parents d99be51 + 971979b commit c36f35d

File tree

4 files changed

+109
-308
lines changed

4 files changed

+109
-308
lines changed

examples/canvas_lines_colors.html

Lines changed: 46 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -50,73 +50,82 @@
5050
<script src="js/renderers/CanvasRenderer.js"></script>
5151

5252
<script src="js/Detector.js"></script>
53-
<script src="js/libs/stats.min.js"></script>
5453
<script src="js/geometries/hilbert3D.js"></script>
54+
<script src="js/geometries/hilbert2D.js"></script>
5555

5656
<script>
5757

5858
if ( ! Detector.webgl ) Detector.addGetWebGLMessage();
5959

60+
var mouseX = 0, mouseY = 0;
6061

61-
var mouseX = 0, mouseY = 0,
62+
var windowHalfX = window.innerWidth / 2;
63+
var windowHalfY = window.innerHeight / 2;
6264

63-
windowHalfX = window.innerWidth / 2,
64-
windowHalfY = window.innerHeight / 2,
65-
66-
camera, scene, renderer, material;
65+
var camera, scene, renderer;
6766

6867
init();
6968
animate();
7069

7170
function init() {
7271

73-
var i, container;
74-
75-
container = document.createElement( 'div' );
76-
document.body.appendChild( container );
77-
7872
camera = new THREE.PerspectiveCamera( 33, window.innerWidth / window.innerHeight, 1, 10000 );
79-
camera.position.z = 700;
73+
camera.position.z = 1000;
8074

8175
scene = new THREE.Scene();
8276

8377
renderer = new THREE.CanvasRenderer();
8478
renderer.setPixelRatio( window.devicePixelRatio );
8579
renderer.setSize( window.innerWidth, window.innerHeight );
86-
container.appendChild( renderer.domElement );
80+
document.body.appendChild( renderer.domElement );
81+
82+
// 2d lines
83+
84+
var geometry2 = new THREE.Geometry(),
85+
points = hilbert2D( new THREE.Vector3( 0, 0, 0 ), 400, 4 ),
86+
colors2 = [];
87+
88+
for ( i = 0; i < points.length; i ++ ) {
89+
90+
geometry2.vertices.push( points[ i ] );
91+
92+
colors2[ i ] = new THREE.Color( 0xffffff );
93+
colors2[ i ].setHSL( i / points.length, 1, 0.5 );
94+
95+
}
96+
97+
geometry2.colors = colors2;
98+
99+
// 3d lines
87100

88101
var geometry3 = new THREE.Geometry(),
89-
points = hilbert3D( new THREE.Vector3( 0,0,0 ), 200.0, 2, 0, 1, 2, 3, 4, 5, 6, 7 ),
102+
points = hilbert3D( new THREE.Vector3( 0, 0, 0 ), 200, 2, 0, 1, 2, 3, 4, 5, 6, 7 ),
90103
colors3 = [];
91104

92105
for ( i = 0; i < points.length; i ++ ) {
93106

94107
geometry3.vertices.push( points[ i ] );
95108

96109
colors3[ i ] = new THREE.Color( 0xffffff );
97-
colors3[ i ].setHSL( i / points.length, 1.0, 0.5 );
110+
colors3[ i ].setHSL( i / points.length, 1, 0.5 );
98111

99112
}
100113

101114
geometry3.colors = colors3;
102115

103116
// lines
104117

105-
material = new THREE.LineBasicMaterial( { color: 0xffffff, opacity: 1, linewidth: 3, vertexColors: THREE.VertexColors } );
106-
107-
var line, p, scale = 0.3, d = 225;
108-
109-
line = new THREE.Line(geometry3, material );
110-
line.scale.x = line.scale.y = line.scale.z = scale*1.5;
111-
line.position.x = 0;
112-
line.position.y = 0;
113-
line.position.z = 0;
114-
scene.add( line );
118+
var material = new THREE.LineBasicMaterial( { color: 0xffffff, linewidth: 3, vertexColors: THREE.VertexColors } );
115119

116-
//
120+
var line3d = new THREE.Line( geometry3, material );
121+
line3d.scale.set( 0.4, 0.4, 0.4 );
122+
line3d.position.set( 200, 0, 0 );
123+
scene.add( line3d );
117124

118-
stats = new Stats();
119-
//container.appendChild( stats.dom );
125+
var line2d = new THREE.Line( geometry2, material );
126+
line2d.scale.copy( line3d.scale );
127+
line2d.position.set( - 200, 0, 0 );
128+
scene.add( line2d );
120129

121130
//
122131

@@ -183,14 +192,12 @@
183192
requestAnimationFrame( animate );
184193
render();
185194

186-
stats.update();
187-
188195
}
189196

190197
function render() {
191198

192-
camera.position.x += ( mouseX - camera.position.x ) * .05;
193-
camera.position.y += ( - mouseY + 200 - camera.position.y ) * .05;
199+
camera.position.x += ( mouseX - camera.position.x ) * 0.05;
200+
camera.position.y += ( - mouseY + 200 - camera.position.y ) * 0.05;
194201

195202
camera.lookAt( scene.position );
196203

@@ -199,11 +206,16 @@
199206
for ( var i = 0; i < scene.children.length; i ++ ) {
200207

201208
var object = scene.children[ i ];
202-
if ( object instanceof THREE.Line ) object.rotation.y = time * ( i % 2 ? 1 : -1 );
209+
210+
if ( object.isLine ) {
211+
212+
object.rotation.y = time * ( i % 2 ? 1 : -1 );
213+
214+
}
203215

204216
}
205217

206-
renderer.render(scene, camera );
218+
renderer.render( scene, camera );
207219

208220
}
209221

examples/canvas_lines_colors_2d.html

Lines changed: 0 additions & 210 deletions
This file was deleted.

examples/files.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -374,7 +374,6 @@ var files = {
374374
"canvas_lights_pointlights",
375375
"canvas_lines",
376376
"canvas_lines_colors",
377-
"canvas_lines_colors_2d",
378377
"canvas_lines_dashed",
379378
"canvas_lines_sphere",
380379
"canvas_materials",

0 commit comments

Comments
 (0)