Merge pull request #16899 from Mugen87/dev34

WestLangley · web-flow · commit bf2e5479daa1 · 2019-06-24T12:48:10.000-04:00
Quaternion: Add missing call of _onChangeCallback in slerp().
diff --git a/src/math/Quaternion.js b/src/math/Quaternion.js
@@ -562,7 +562,10 @@ Object.assign( Quaternion.prototype, {
 			this._y = s * y + t * this._y;
 			this._z = s * z + t * this._z;
 
-			return this.normalize();
+			this.normalize();
+			this._onChangeCallback();
+
+			return this;
 
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -562,7 +562,10 @@ Object.assign( Quaternion.prototype, {`
`562`	`562`	`this._y = s * y + t * this._y;`
`563`	`563`	`this._z = s * z + t * this._z;`
`564`	`564`
`565`		`- return this.normalize();`
	`565`	`+ this.normalize();`
	`566`	`+ this._onChangeCallback();`
	`567`	`+`
	`568`	`+ return this;`
`566`	`569`
`567`	`570`	`}`
`568`	`571`