Skip to content

Commit accd150

Browse files
s-rigaudSamuel Rigaud
andauthored
Types: fx color and some nodes (#30325)
Co-authored-by: Samuel Rigaud <[email protected]>
1 parent a34d43c commit accd150

File tree

3 files changed

+12
-10
lines changed

3 files changed

+12
-10
lines changed

src/nodes/accessors/TextureNode.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -384,11 +384,11 @@ class TextureNode extends UniformNode {
384384
* @param {NodeBuilder} builder - The current node builder.
385385
* @param {String} textureProperty - The texture property.
386386
* @param {String} uvSnippet - The uv snippet.
387-
* @param {String} levelSnippet - The level snippet.
388-
* @param {String} biasSnippet - The bias snippet.
389-
* @param {String} depthSnippet - The depth snippet.
390-
* @param {String} compareSnippet - The compare snippet.
391-
* @param {String} gradSnippet - The grad snippet.
387+
* @param {String?} levelSnippet - The level snippet.
388+
* @param {String?} biasSnippet - The bias snippet.
389+
* @param {String?} depthSnippet - The depth snippet.
390+
* @param {String?} compareSnippet - The compare snippet.
391+
* @param {Array<String>?} gradSnippet - The grad snippet.
392392
* @return {String} The generated code snippet.
393393
*/
394394
generateSnippet( builder, textureProperty, uvSnippet, levelSnippet, biasSnippet, depthSnippet, compareSnippet, gradSnippet ) {

src/nodes/core/Node.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -691,7 +691,7 @@ class Node extends EventDispatcher {
691691
/**
692692
* Returns the child nodes as a JSON object.
693693
*
694-
* @return {Object} The serialized child objects as JSON.
694+
* @return {Array<Object>} An iterable list of serialized child objects as JSON.
695695
*/
696696
getSerializeChildren() {
697697

src/renderers/common/Color4.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,12 @@ class Color4 extends Color {
1212

1313
/**
1414
* Constructs a new four-component color.
15+
* You can also pass a single THREE.Color, hex or
16+
* string argument to this constructor.
1517
*
16-
* @param {Number|String} r - The red value.
17-
* @param {Number} g - The green value.
18-
* @param {Number} b - The blue value.
18+
* @param {Number|String} [r=1] - The red value.
19+
* @param {Number} [g=1] - The green value.
20+
* @param {Number} [b=1] - The blue value.
1921
* @param {Number} [a=1] - The alpha value.
2022
*/
2123
constructor( r, g, b, a = 1 ) {
@@ -28,7 +30,7 @@ class Color4 extends Color {
2830

2931
/**
3032
* Overwrites the default to honor alpha.
31-
* You can also passed a single THREE.Color, hex or
33+
* You can also pass a single THREE.Color, hex or
3234
* string argument to this method.
3335
*
3436
* @param {Number|String} r - The red value.

0 commit comments

Comments
 (0)