Skip to content

Commit a0c48d6

Browse files
authored
Merge pull request #16557 from sciecode/dev14
EffectComposer: Clock instead of Date
2 parents 50a06be + a2e92d9 commit a0c48d6

File tree

3 files changed

+7
-8
lines changed

3 files changed

+7
-8
lines changed

examples/js/postprocessing/EffectComposer.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ THREE.EffectComposer = function ( renderer, renderTarget ) {
5858

5959
this.copyPass = new THREE.ShaderPass( THREE.CopyShader );
6060

61-
this._previousFrameTime = Date.now();
61+
this.clock = new THREE.Clock();
6262

6363
};
6464

@@ -109,12 +109,10 @@ Object.assign( THREE.EffectComposer.prototype, {
109109

110110
if ( deltaTime === undefined ) {
111111

112-
deltaTime = ( Date.now() - this._previousFrameTime ) * 0.001;
112+
deltaTime = this.clock.getDelta();
113113

114114
}
115115

116-
this._previousFrameTime = Date.now();
117-
118116
var currentRenderTarget = this.renderer.getRenderTarget();
119117

120118
var maskActive = false;

examples/jsm/postprocessing/EffectComposer.d.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import {
2+
Clock,
23
WebGLRenderer,
34
WebGLRenderTarget,
45
} from '../../../src/Three';
@@ -15,6 +16,7 @@ export class EffectComposer {
1516
readBuffer: WebGLRenderTarget;
1617
passes: Pass[];
1718
copyPass: ShaderPass;
19+
clock: Clock;
1820

1921
swapBuffers(): void;
2022
addPass(pass: Pass): void;

examples/jsm/postprocessing/EffectComposer.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import {
99
PlaneBufferGeometry,
1010
RGBAFormat,
1111
Vector2,
12+
Clock,
1213
WebGLRenderTarget
1314
} from "../../../build/three.module.js";
1415
import { CopyShader } from "../shaders/CopyShader.js";
@@ -72,7 +73,7 @@ var EffectComposer = function ( renderer, renderTarget ) {
7273

7374
this.copyPass = new ShaderPass( CopyShader );
7475

75-
this._previousFrameTime = Date.now();
76+
this.clock = new Clock();
7677

7778
};
7879

@@ -123,12 +124,10 @@ Object.assign( EffectComposer.prototype, {
123124

124125
if ( deltaTime === undefined ) {
125126

126-
deltaTime = ( Date.now() - this._previousFrameTime ) * 0.001;
127+
deltaTime = this.clock.getDelta();
127128

128129
}
129130

130-
this._previousFrameTime = Date.now();
131-
132131
var currentRenderTarget = this.renderer.getRenderTarget();
133132

134133
var maskActive = false;

0 commit comments

Comments
 (0)