Skip to content

Commit 52c4153

Browse files
committed
ColladaLoader: Clean up.
1 parent e61267d commit 52c4153

File tree

2 files changed

+12
-30
lines changed

2 files changed

+12
-30
lines changed

examples/js/exporters/ColladaExporter.js

Lines changed: 6 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -220,13 +220,9 @@ THREE.ColladaExporter.prototype = {
220220
bufferGeometry.groups :
221221
[ { start: 0, count: indexCount, materialIndex: 0 } ];
222222

223-
var gnode = `<geometry id="${ meshid }"` +
224-
(
225-
g.name ?
226-
` name="${ g.name }"` :
227-
''
228-
) +
229-
'><mesh>';
223+
224+
var gname = g.name ? ` name="${ g.name }"` : '';
225+
var gnode = `<geometry id="${ meshid }"${ gname }><mesh>`;
230226

231227
// define the geometry node and the vertices for the geometry
232228
var posName = `${ meshid }-position`;
@@ -499,15 +495,10 @@ THREE.ColladaExporter.prototype = {
499495

500496
'</effect>';
501497

502-
var materialNode = `<material id="${ matid }"` +
503-
(
504-
m.name ?
505-
` name="${ m.name }` :
506-
''
507-
) +
508-
`"><instance_effect url="#${ matid }-effect" /></material>`;
498+
var materialName = m.name ? ` name="${ m.name }"` : '';
499+
var materialNode = `<material id="${ matid }"${ materialName }><instance_effect url="#${ matid }-effect" /></material>`;
509500

510-
libraryMaterials.push(materialNode);
501+
libraryMaterials.push( materialNode );
511502
libraryEffects.push( effectnode );
512503
materialMap.set( m, matid );
513504

examples/jsm/exporters/ColladaExporter.js

Lines changed: 6 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -231,13 +231,9 @@ ColladaExporter.prototype = {
231231
bufferGeometry.groups :
232232
[ { start: 0, count: indexCount, materialIndex: 0 } ];
233233

234-
var gnode = `<geometry id="${ meshid }"` +
235-
(
236-
g.name ?
237-
` name="${ g.name }"` :
238-
''
239-
) +
240-
'><mesh>';
234+
235+
var gname = g.name ? ` name="${ g.name }"` : '';
236+
var gnode = `<geometry id="${ meshid }"${ gname }><mesh>`;
241237

242238
// define the geometry node and the vertices for the geometry
243239
var posName = `${ meshid }-position`;
@@ -510,15 +506,10 @@ ColladaExporter.prototype = {
510506

511507
'</effect>';
512508

513-
var materialNode = `<material id="${ matid }"` +
514-
(
515-
m.name ?
516-
` name="${ m.name }` :
517-
''
518-
) +
519-
`"><instance_effect url="#${ matid }-effect" /></material>`;
509+
var materialName = m.name ? ` name="${ m.name }"` : '';
510+
var materialNode = `<material id="${ matid }"${ materialName }><instance_effect url="#${ matid }-effect" /></material>`;
520511

521-
libraryMaterials.push(materialNode);
512+
libraryMaterials.push( materialNode );
522513
libraryEffects.push( effectnode );
523514
materialMap.set( m, matid );
524515

0 commit comments

Comments
 (0)