Skip to content

Commit 466eb72

Browse files
authored
Merge pull request #17513 from gero3/removecapabilitiesFromWebglProgram
WebGLProgram: remove capabilities from constructor
2 parents f4cc357 + 085ad27 commit 466eb72

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

src/renderers/webgl/WebGLProgram.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -371,7 +371,7 @@ function generateEnvMapBlendingDefine( parameters, material ) {
371371

372372
}
373373

374-
function WebGLProgram( renderer, extensions, code, material, shader, parameters, capabilities ) {
374+
function WebGLProgram( renderer, extensions, code, material, shader, parameters ) {
375375

376376
var gl = renderer.getContext();
377377

@@ -387,7 +387,7 @@ function WebGLProgram( renderer, extensions, code, material, shader, parameters,
387387

388388
var gammaFactorDefine = ( renderer.gammaFactor > 0 ) ? renderer.gammaFactor : 1.0;
389389

390-
var customExtensions = capabilities.isWebGL2 ? '' : generateExtensions( material.extensions, parameters, extensions );
390+
var customExtensions = parameters.isWebGL2 ? '' : generateExtensions( material.extensions, parameters, extensions );
391391

392392
var customDefines = generateDefines( defines );
393393

@@ -481,7 +481,7 @@ function WebGLProgram( renderer, extensions, code, material, shader, parameters,
481481
parameters.sizeAttenuation ? '#define USE_SIZEATTENUATION' : '',
482482

483483
parameters.logarithmicDepthBuffer ? '#define USE_LOGDEPTHBUF' : '',
484-
parameters.logarithmicDepthBuffer && ( capabilities.isWebGL2 || extensions.get( 'EXT_frag_depth' ) ) ? '#define USE_LOGDEPTHBUF_EXT' : '',
484+
parameters.logarithmicDepthBuffer && ( parameters.isWebGL2 || extensions.get( 'EXT_frag_depth' ) ) ? '#define USE_LOGDEPTHBUF_EXT' : '',
485485
'uniform mat4 modelMatrix;',
486486
'uniform vec3 cameraPosition;',
487487

@@ -614,9 +614,9 @@ function WebGLProgram( renderer, extensions, code, material, shader, parameters,
614614
parameters.physicallyCorrectLights ? '#define PHYSICALLY_CORRECT_LIGHTS' : '',
615615

616616
parameters.logarithmicDepthBuffer ? '#define USE_LOGDEPTHBUF' : '',
617-
parameters.logarithmicDepthBuffer && ( capabilities.isWebGL2 || extensions.get( 'EXT_frag_depth' ) ) ? '#define USE_LOGDEPTHBUF_EXT' : '',
617+
parameters.logarithmicDepthBuffer && ( parameters.isWebGL2 || extensions.get( 'EXT_frag_depth' ) ) ? '#define USE_LOGDEPTHBUF_EXT' : '',
618618

619-
( ( material.extensions ? material.extensions.shaderTextureLOD : false ) || parameters.envMap ) && ( capabilities.isWebGL2 || extensions.get( 'EXT_shader_texture_lod' ) ) ? '#define TEXTURE_LOD_EXT' : '',
619+
( ( material.extensions ? material.extensions.shaderTextureLOD : false ) || parameters.envMap ) && ( parameters.isWebGL2 || extensions.get( 'EXT_shader_texture_lod' ) ) ? '#define TEXTURE_LOD_EXT' : '',
620620

621621
'uniform vec3 cameraPosition;',
622622

@@ -660,7 +660,7 @@ function WebGLProgram( renderer, extensions, code, material, shader, parameters,
660660
vertexShader = unrollLoops( vertexShader );
661661
fragmentShader = unrollLoops( fragmentShader );
662662

663-
if ( capabilities.isWebGL2 && ! material.isRawShaderMaterial ) {
663+
if ( parameters.isWebGL2 && ! material.isRawShaderMaterial ) {
664664

665665
var isGLSL3ShaderMaterial = false;
666666

src/renderers/webgl/WebGLPrograms.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,7 @@ function WebGLPrograms( renderer, extensions, capabilities ) {
137137
shaderID: shaderID,
138138

139139
precision: precision,
140+
isWebGL2: capabilities.isWebGL2,
140141
supportsVertexTextures: capabilities.vertexTextures,
141142
outputEncoding: getTextureEncodingFromMap( ( ! currentRenderTarget ) ? null : currentRenderTarget.texture, renderer.gammaOutput ),
142143
map: !! material.map,
@@ -289,7 +290,7 @@ function WebGLPrograms( renderer, extensions, capabilities ) {
289290

290291
if ( program === undefined ) {
291292

292-
program = new WebGLProgram( renderer, extensions, code, material, shader, parameters, capabilities );
293+
program = new WebGLProgram( renderer, extensions, code, material, shader, parameters );
293294
programs.push( program );
294295

295296
}

0 commit comments

Comments
 (0)