Skip to content

Commit 3220e98

Browse files
authored
USDZExporter: Improve material prop types and setup (#32008)
1 parent 9178da5 commit 3220e98

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

examples/jsm/exporters/USDZExporter.js

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -794,13 +794,13 @@ function buildMaterial( material, textures, quickLookCompatible = false ) {
794794
'uniform token info:id = "UsdPrimvarReader_float2"'
795795
);
796796
primvarReaderNode.addProperty( 'float2 inputs:fallback = (0.0, 0.0)' );
797-
primvarReaderNode.addProperty( `token inputs:varname = "${uv}"` );
797+
primvarReaderNode.addProperty( `string inputs:varname = "${uv}"` );
798798
primvarReaderNode.addProperty( 'float2 outputs:result' );
799799

800800
const transform2dNode = new USDNode( `Transform2d_${mapType}`, 'Shader' );
801801
transform2dNode.addProperty( 'uniform token info:id = "UsdTransform2d"' );
802802
transform2dNode.addProperty(
803-
`token inputs:in.connect = </Materials/Material_${material.id}/PrimvarReader_${mapType}.outputs:result>`
803+
`float2 inputs:in.connect = </Materials/Material_${material.id}/PrimvarReader_${mapType}.outputs:result>`
804804
);
805805
transform2dNode.addProperty(
806806
`float inputs:rotation = ${( rotation * ( 180 / Math.PI ) ).toFixed(
@@ -831,6 +831,13 @@ function buildMaterial( material, textures, quickLookCompatible = false ) {
831831

832832
}
833833

834+
if ( mapType === 'normal' ) {
835+
836+
textureNode.addProperty( 'float4 inputs:scale = (2, 2, 2, 1)' );
837+
textureNode.addProperty( 'float4 inputs:bias = (-1, -1, -1, 0)' );
838+
839+
}
840+
834841
textureNode.addProperty(
835842
`token inputs:sourceColorSpace = "${
836843
texture.colorSpace === NoColorSpace ? 'raw' : 'sRGB'

0 commit comments

Comments
 (0)