AsciiEffect: avoid useless split operations

Samuel Rigaud · Samuel Rigaud · commit 28739e42ca6f · 2025-03-07T11:00:22.000-05:00
diff --git a/examples/jsm/effects/AsciiEffect.js b/examples/jsm/effects/AsciiEffect.js
@@ -118,8 +118,6 @@ class AsciiEffect {
 		}
 
 
-		const aDefaultCharList = ( ' .,:;i1tfLCG08@' ).split( '' );
-		const aDefaultColorCharList = ( ' CGO08@' ).split( '' );
 		const strFont = 'courier new, monospace';
 
 		const oCanvasImg = renderer.domElement;
@@ -138,9 +136,11 @@ class AsciiEffect {
 
 		}
 
+		const aDefaultCharList = ( ' .,:;i1tfLCG08@' ).split( '' );
+		const aDefaultColorCharList = ( ' CGO08@' ).split( '' );
 		let aCharList = ( bColor ? aDefaultColorCharList : aDefaultCharList );
 
-		if ( charSet ) aCharList = charSet;
+		if ( charSet ) aCharList = ( charSet ).split( '' );
 
 		// Setup dom
 

Original file line number	Diff line number	Diff line change
`@@ -118,8 +118,6 @@ class AsciiEffect {`
`118`	`118`	`}`
`119`	`119`
`120`	`120`
`121`		`- const aDefaultCharList = ( ' .,:;i1tfLCG08@' ).split( '' );`
`122`		`- const aDefaultColorCharList = ( ' CGO08@' ).split( '' );`
`123`	`121`	`const strFont = 'courier new, monospace';`
`124`	`122`
`125`	`123`	`const oCanvasImg = renderer.domElement;`
`@@ -138,9 +136,11 @@ class AsciiEffect {`
`138`	`136`
`139`	`137`	`}`
`140`	`138`
	`139`	`+ const aDefaultCharList = ( ' .,:;i1tfLCG08@' ).split( '' );`
	`140`	`+ const aDefaultColorCharList = ( ' CGO08@' ).split( '' );`
`141`	`141`	`let aCharList = ( bColor ? aDefaultColorCharList : aDefaultCharList );`
`142`	`142`
`143`		`- if ( charSet ) aCharList = charSet;`
	`143`	`+ if ( charSet ) aCharList = ( charSet ).split( '' );`
`144`	`144`
`145`	`145`	`// Setup dom`
`146`	`146`