Skip to content

Commit 23ebe26

Browse files
committed
Web*RManager: framebufferScaleFactor to setFramebufferScaleFactor().
1 parent e7dcca7 commit 23ebe26

File tree

2 files changed

+19
-5
lines changed

2 files changed

+19
-5
lines changed

src/renderers/webvr/WebVRManager.js

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@ function WebVRManager( renderer ) {
2525
var standingMatrix = new Matrix4();
2626
var standingMatrixInverse = new Matrix4();
2727

28+
var framebufferScaleFactor = 1.0;
29+
2830
var frameOfReferenceType = 'stage';
2931

3032
if ( typeof window !== 'undefined' && 'VRFrameData' in window ) {
@@ -65,8 +67,8 @@ function WebVRManager( renderer ) {
6567
if ( isPresenting() ) {
6668

6769
var eyeParameters = device.getEyeParameters( 'left' );
68-
var renderWidth = eyeParameters.renderWidth * scope.framebufferScaleFactor;
69-
var renderHeight = eyeParameters.renderHeight * scope.framebufferScaleFactor;
70+
var renderWidth = eyeParameters.renderWidth * framebufferScaleFactor;
71+
var renderHeight = eyeParameters.renderHeight * framebufferScaleFactor;
7072

7173
currentPixelRatio = renderer.getPixelRatio();
7274
currentSize = renderer.getSize();
@@ -194,7 +196,6 @@ function WebVRManager( renderer ) {
194196
return controller;
195197

196198
};
197-
this.framebufferScaleFactor = 1.0;
198199

199200
this.getDevice = function () {
200201

@@ -210,6 +211,12 @@ function WebVRManager( renderer ) {
210211

211212
};
212213

214+
this.setFramebufferScaleFactor = function ( value ) {
215+
216+
framebufferScaleFactor = value;
217+
218+
};
219+
213220
this.setFrameOfReferenceType = function ( value ) {
214221

215222
frameOfReferenceType = value;

src/renderers/webvr/WebXRManager.js

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@ function WebXRManager( renderer ) {
1616
var device = null;
1717
var session = null;
1818

19+
var framebufferScaleFactor = 1.0;
20+
1921
var frameOfReference = null;
2022
var frameOfReferenceType = 'stage';
2123

@@ -47,7 +49,6 @@ function WebXRManager( renderer ) {
4749
//
4850

4951
this.enabled = false;
50-
this.framebufferScaleFactor = 1.0;
5152

5253
this.getController = function ( id ) {
5354

@@ -96,6 +97,12 @@ function WebXRManager( renderer ) {
9697

9798
}
9899

100+
this.setFramebufferScaleFactor = function ( value ) {
101+
102+
framebufferScaleFactor = value;
103+
104+
};
105+
99106
this.setFrameOfReferenceType = function ( value ) {
100107

101108
frameOfReferenceType = value;
@@ -113,7 +120,7 @@ function WebXRManager( renderer ) {
113120
session.addEventListener( 'selectend', onSessionEvent );
114121
session.addEventListener( 'end', onSessionEnd );
115122

116-
session.baseLayer = new XRWebGLLayer( session, gl, { framebufferScaleFactor: this.framebufferScaleFactor } );
123+
session.baseLayer = new XRWebGLLayer( session, gl, { framebufferScaleFactor: framebufferScaleFactor } );
117124
session.requestFrameOfReference( frameOfReferenceType ).then( function ( value ) {
118125

119126
frameOfReference = value;

0 commit comments

Comments
 (0)