Skip to content

Commit 1a6bcc9

Browse files
authored
Merge pull request #15336 from Mugen87/dev19
ObjectLoader: Add fallback for Geometry
2 parents ac2c912 + d0109aa commit 1a6bcc9

File tree

2 files changed

+15
-5
lines changed

2 files changed

+15
-5
lines changed

examples/js/loaders/deprecated/JSONLoader.js renamed to examples/js/loaders/deprecated/LegacyJSONLoader.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33
* @author alteredq / http://alteredqualia.com/
44
*/
55

6-
THREE.JSONLoader = ( function () {
6+
THREE.LegacyJSONLoader = ( function () {
77

8-
function JSONLoader( manager ) {
8+
function LegacyJSONLoader( manager ) {
99

1010
if ( typeof manager === 'boolean' ) {
1111

@@ -20,7 +20,7 @@ THREE.JSONLoader = ( function () {
2020

2121
}
2222

23-
Object.assign( JSONLoader.prototype, {
23+
Object.assign( LegacyJSONLoader.prototype, {
2424

2525
crossOrigin: 'anonymous',
2626

@@ -573,6 +573,6 @@ THREE.JSONLoader = ( function () {
573573

574574
} );
575575

576-
return JSONLoader;
576+
return LegacyJSONLoader;
577577

578578
} )();

src/loaders/ObjectLoader.js

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -422,7 +422,17 @@ Object.assign( ObjectLoader.prototype, {
422422

423423
case 'Geometry':
424424

425-
console.error( 'THREE.ObjectLoader: "Geometry" is no longer supported.' );
425+
if ( 'THREE' in window && 'LegacyJSONLoader' in THREE ) {
426+
427+
var geometryLoader = new THREE.LegacyJSONLoader();
428+
geometry = geometryLoader.parse( data, this.resourcePath ).geometry;
429+
430+
431+
} else {
432+
433+
console.error( 'THREE.ObjectLoader: You have to import LegacyJSONLoader in order load geometry data of type "Geometry".' );
434+
435+
}
426436

427437
break;
428438

0 commit comments

Comments
 (0)