Skip to content

Commit 10f68af

Browse files
committed
Tests: Fix remaining warnings.
1 parent eb96029 commit 10f68af

File tree

4 files changed

+27
-14
lines changed

4 files changed

+27
-14
lines changed

test/unit/src/animation/KeyframeTrack.tests.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
/* global QUnit */
22

3-
import { KeyframeTrack } from '../../../../src/animation/KeyframeTrack';
43
import { NumberKeyframeTrack } from '../../../../src/animation/tracks/NumberKeyframeTrack';
4+
import { CONSOLE_LEVEL } from '../../utils/console-wrapper';
55

66
export default QUnit.module( 'Animation', () => {
77

@@ -100,7 +100,10 @@ export default QUnit.module( 'Animation', () => {
100100
var invalidTrack = new NumberKeyframeTrack( '.material.opacity', [ 0, 1 ], [ 0, NaN ] );
101101

102102
assert.ok( validTrack.validate() );
103+
104+
console.level = CONSOLE_LEVEL.OFF;
103105
assert.notOk( invalidTrack.validate() );
106+
console.level = CONSOLE_LEVEL.DEFAULT;
104107

105108
} );
106109

test/unit/src/core/BufferGeometry.tests.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import {
2121
y,
2222
z
2323
} from '../math/Constants.tests';
24+
import { CONSOLE_LEVEL } from '../../utils/console-wrapper';
2425

2526
var DegToRad = Math.PI / 180;
2627

@@ -769,7 +770,10 @@ export default QUnit.module( 'Core', () => {
769770

770771
}
771772

773+
console.level = CONSOLE_LEVEL.ERROR;
772774
geometry1.merge( geometry2 );
775+
console.level = CONSOLE_LEVEL.DEFAULT;
776+
773777
assert.ok( attr[ 0 ] === 4 && attr[ 1 ] === 5 && attr[ 2 ] === 6, "copied the 3 attributes without offset" );
774778

775779
} );

test/unit/src/helpers/BoxHelper.tests.js

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -13,23 +13,13 @@ export default QUnit.module( 'Helpers', () => {
1313
var geometries = undefined;
1414
hooks.beforeEach( function () {
1515

16-
const parameters = {
17-
radius: 10,
18-
widthSegments: 20,
19-
heightSegments: 30,
20-
phiStart: 0.5,
21-
phiLength: 1.0,
22-
thetaStart: 0.4,
23-
thetaLength: 2.0,
24-
};
25-
2616
// Test with a normal cube and a box helper
27-
var boxGeometry = new BoxGeometry( parameters.diameter );
17+
var boxGeometry = new BoxGeometry();
2818
var box = new Mesh( boxGeometry );
2919
var boxHelper = new BoxHelper( box );
3020

3121
// The same should happen with a comparable sphere
32-
var sphereGeometry = new SphereGeometry( parameters.diameter / 2 );
22+
var sphereGeometry = new SphereGeometry();
3323
var sphere = new Mesh( sphereGeometry );
3424
var sphereBoxHelper = new BoxHelper( sphere );
3525

test/unit/src/math/Color.tests.js

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ export default QUnit.module( 'Maths', () => {
125125
assert.ok( hsl.l == 0.75, "lightness: " + hsl.l );
126126

127127
hsl = { h: 0, s: 0, l: 0 };
128-
a.setStyle( "hsl(270,50%,75%,0.5)" );
128+
a.setStyle( "hsl(270,50%,75%)" );
129129
a.getHSL( hsl );
130130
assert.ok( hsl.h == 0.75, "hue: " + hsl.h );
131131
assert.ok( hsl.s == 0.5, "saturation: " + hsl.s );
@@ -528,7 +528,11 @@ export default QUnit.module( 'Maths', () => {
528528
QUnit.test( "setStyleRGBAPercent", ( assert ) => {
529529

530530
var c = new Color();
531+
532+
console.level = CONSOLE_LEVEL.ERROR;
531533
c.setStyle( 'rgba(100%,50%,10%, 0.5)' );
534+
console.level = CONSOLE_LEVEL.DEFAULT;
535+
532536
assert.ok( c.r == 1, "Red: " + c.r );
533537
assert.ok( c.g == 0.5, "Green: " + c.g );
534538
assert.ok( c.b == 0.1, "Blue: " + c.b );
@@ -548,7 +552,11 @@ export default QUnit.module( 'Maths', () => {
548552
QUnit.test( "setStyleRGBAPercentWithSpaces", ( assert ) => {
549553

550554
var c = new Color();
555+
556+
console.level = CONSOLE_LEVEL.ERROR;
551557
c.setStyle( 'rgba( 100% ,50% , 10%, 0.5 )' );
558+
console.level = CONSOLE_LEVEL.DEFAULT;
559+
552560
assert.ok( c.r == 1, "Red: " + c.r );
553561
assert.ok( c.g == 0.5, "Green: " + c.g );
554562
assert.ok( c.b == 0.1, "Blue: " + c.b );
@@ -568,7 +576,11 @@ export default QUnit.module( 'Maths', () => {
568576
QUnit.test( "setStyleHSLARed", ( assert ) => {
569577

570578
var c = new Color();
579+
580+
console.level = CONSOLE_LEVEL.ERROR;
571581
c.setStyle( 'hsla(360,100%,50%,0.5)' );
582+
console.level = CONSOLE_LEVEL.DEFAULT;
583+
572584
assert.ok( c.r == 1, "Red: " + c.r );
573585
assert.ok( c.g === 0, "Green: " + c.g );
574586
assert.ok( c.b === 0, "Blue: " + c.b );
@@ -588,7 +600,11 @@ export default QUnit.module( 'Maths', () => {
588600
QUnit.test( "setStyleHSLARedWithSpaces", ( assert ) => {
589601

590602
var c = new Color();
603+
604+
console.level = CONSOLE_LEVEL.ERROR;
591605
c.setStyle( 'hsla( 360, 100% , 50%, 0.5 )' );
606+
console.level = CONSOLE_LEVEL.DEFAULT;
607+
592608
assert.ok( c.r == 1, "Red: " + c.r );
593609
assert.ok( c.g === 0, "Green: " + c.g );
594610
assert.ok( c.b === 0, "Blue: " + c.b );

0 commit comments

Comments
 (0)