Skip to content

Commit 03cc77f

Browse files
authored
Euler: Default value for ES6. (#21961)
1 parent 5bd6f6d commit 03cc77f

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

src/math/Euler.js

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -69,12 +69,12 @@ class Euler {
6969

7070
}
7171

72-
set( x, y, z, order ) {
72+
set( x, y, z, order = this._order ) {
7373

7474
this._x = x;
7575
this._y = y;
7676
this._z = z;
77-
this._order = order || this._order;
77+
this._order = order;
7878

7979
this._onChangeCallback();
8080

@@ -101,7 +101,7 @@ class Euler {
101101

102102
}
103103

104-
setFromRotationMatrix( m, order, update ) {
104+
setFromRotationMatrix( m, order = this._order, update = true ) {
105105

106106
// assumes the upper 3x3 of m is a pure rotation matrix (i.e, unscaled)
107107

@@ -110,8 +110,6 @@ class Euler {
110110
const m21 = te[ 1 ], m22 = te[ 5 ], m23 = te[ 9 ];
111111
const m31 = te[ 2 ], m32 = te[ 6 ], m33 = te[ 10 ];
112112

113-
order = order || this._order;
114-
115113
switch ( order ) {
116114

117115
case 'XYZ':
@@ -230,7 +228,7 @@ class Euler {
230228

231229
this._order = order;
232230

233-
if ( update !== false ) this._onChangeCallback();
231+
if ( update ) this._onChangeCallback();
234232

235233
return this;
236234

@@ -244,9 +242,9 @@ class Euler {
244242

245243
}
246244

247-
setFromVector3( v, order ) {
245+
setFromVector3( v, order = this._order ) {
248246

249-
return this.set( v.x, v.y, v.z, order || this._order );
247+
return this.set( v.x, v.y, v.z, order );
250248

251249
}
252250

0 commit comments

Comments
 (0)