Fixes choice prompt crash (#1393)

Also fixed the dialog min with we don't get correct height measures when lists are included in the layout.

Author: keianhzo

app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/prompts/ChoicePromptWidget.java

@@ -146,13 +146,18 @@ protected void onDismiss() {
 
     @Override
     public void show(@ShowFlags int aShowFlags) {
-        show(aShowFlags);
+        super.show(aShowFlags);
         for (int i = 0; i < mListItems.length; i++) {
             mList.setItemChecked(i, mListItems[i].mChoice.selected);
         }
         mAdapter.notifyDataSetChanged();
     }
 
+    @Override
+    public int getMinHeight() {
+        return  WidgetPlacement.dpDimension(getContext(), R.dimen.prompt_min_height);
+    }
+
     public void setDelegate(GeckoSession.PromptDelegate.ChoiceCallback delegate) {
         mCallback = delegate;
     }

app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/prompts/PromptWidget.java

@@ -68,7 +68,9 @@ protected void initializeWidgetPlacement(WidgetPlacement aPlacement) {
     public void show(@ShowFlags int aShowFlags) {
         mLayout.measure(View.MeasureSpec.makeMeasureSpec(0, MeasureSpec.UNSPECIFIED),
                         View.MeasureSpec.makeMeasureSpec(0, MeasureSpec.UNSPECIFIED));
-        mWidgetPlacement.height = (int)(mLayout.getMeasuredHeight()/mWidgetPlacement.density);
+        mWidgetPlacement.height = (getMinHeight() == 0) ?
+                (int)(mLayout.getMeasuredHeight()/mWidgetPlacement.density) :
+                getMinHeight();
         super.show(aShowFlags);
 
         mWidgetManager.pushWorldBrightness(this, WidgetManagerDelegate.DEFAULT_DIM_BRIGHTNESS);
@@ -99,4 +101,8 @@ public void onGlobalFocusChanged(View oldFocus, View newFocus) {
         }
     }
 
+    public int getMinHeight() {
+        return 0;
+    }
+
 }

app/src/main/res/values/dimen.xml

@@ -145,6 +145,7 @@
     <dimen name="prompt_content_max_height">450dp</dimen>
     <dimen name="prompt_choice_min_height">300dp</dimen>
     <dimen name="prompt_choice_max_height">520dp</dimen>
+    <dimen name="prompt_min_height">400dp</dimen>
 
     <!-- Crash Dialog prompt -->
     <dimen name="crash_dialog_width">640dp</dimen>