Skip to content

Commit 10bc635

Browse files
Merge pull request #20271 from timvandermeij/integration-tests-pending
Replace manual returns with `pending` in the integration tests
2 parents 1cae8e2 + ffeaa91 commit 10bc635

File tree

3 files changed

+13
-19
lines changed

3 files changed

+13
-19
lines changed

test/integration/highlight_editor_spec.mjs

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1072,14 +1072,12 @@ describe("Highlight Editor", () => {
10721072
it("must check that an highlight can be left with the keyboard", async () => {
10731073
await Promise.all(
10741074
pages.map(async ([browserName, page]) => {
1075-
await switchToHighlight(page);
1076-
10771075
if (browserName === "chrome") {
1078-
// Unfortunately, we can't test this on Chrome because we can't set
1079-
// the caret browsing mode to true.
1080-
return;
1076+
pending("Caret browsing mode cannot be used in Chrome.");
10811077
}
10821078

1079+
await switchToHighlight(page);
1080+
10831081
let rect = await getSpanRectFromText(
10841082
page,
10851083
1,
@@ -1855,9 +1853,7 @@ describe("Highlight Editor", () => {
18551853
await Promise.all(
18561854
pages.map(async ([browserName, page]) => {
18571855
if (navigator.platform.includes("Win")) {
1858-
// Skip the test on Windows because it permafails.
1859-
// TODO: Remove this check once #20136 is fixed.
1860-
return;
1856+
pending("Fails consistently on Windows (issue #20136).");
18611857
}
18621858

18631859
await switchToHighlight(page);

test/integration/ink_editor_spec.mjs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1217,10 +1217,9 @@ describe("The pen-drawn shape must maintain correct curvature regardless of the
12171217
await Promise.all(
12181218
pages.map(async ([browserName, page]) => {
12191219
if (browserName === "chrome" && navigator.platform.includes("Win")) {
1220-
// Skip the test for Chrome on Windows because it doesn't allow to
1221-
// have elements outside the viewport and thus permafails with e.g.
1222-
// `Cannot move beyond viewport (x: -32, y: 241)`.
1223-
return;
1220+
pending(
1221+
"Chrome on Windows doesn't allow having elements outside the viewport."
1222+
);
12241223
}
12251224

12261225
await switchToInk(page);

test/integration/viewer_spec.mjs

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1375,15 +1375,14 @@ describe("PDF viewer", () => {
13751375
await Promise.all(
13761376
pages.map(async ([browserName, page]) => {
13771377
if (browserName === "firefox") {
1378-
// Firefox does not support touch events on devices
1379-
// with no touch screen.
1380-
return;
1378+
pending(
1379+
"Touch events are not supported on devices without touch screen in Firefox."
1380+
);
13811381
}
13821382
if (browserName === "chrome") {
1383-
// Skip the test for Chrome as it doesn't support pinch zoom
1384-
// emulation for WebDriver BiDi yet.
1385-
// TODO: Remove this check once the issue is fixed.
1386-
return;
1383+
pending(
1384+
"Pinch zoom emulation is not supported for WebDriver BiDi in Chrome."
1385+
);
13871386
}
13881387

13891388
const rect = await getSpanRectFromText(page, 1, "type-stable");

0 commit comments

Comments
 (0)