Skip to content

Commit d64b398

Browse files
committed
fix: Correct issue of stearing when in external mode even if not engaged and entering in fault
1 parent 1c21e7e commit d64b398

File tree

1 file changed

+14
-15
lines changed

1 file changed

+14
-15
lines changed

selfdrive/car/toyota/carcontroller.py

Lines changed: 14 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -72,26 +72,25 @@ def update(self, CC, CS, now_nanos):
7272
new_steer = int(round(actuators.steer * 1000))
7373
apply_steer = new_steer
7474
if self.CCP.tuvParams.torqueRateLimiting:
75-
apply_steer = apply_meas_steer_torque_limits(new_steer, self.last_steer, CS.out.steeringTorqueEps, self.CCP)
76-
apply_steer_req = 1
75+
apply_steer = apply_meas_steer_torque_limits(new_steer, self.last_steer, CS.out.steeringTorqueEps, self.CCP)
7776

7877
else:
7978
new_steer = int(round(actuators.steer * self.CCP.STEER_MAX))
8079
apply_steer = apply_meas_steer_torque_limits(new_steer, self.last_steer, CS.out.steeringTorqueEps, self.CCP)
8180

82-
# Count up to MAX_STEER_RATE_FRAMES, at which point we need to cut torque to avoid a steering fault
83-
if lat_active and abs(CS.out.steeringRateDeg) >= MAX_STEER_RATE:
84-
self.steer_rate_counter += 1
85-
else:
86-
self.steer_rate_counter = 0
87-
88-
apply_steer_req = 1
89-
if not lat_active:
90-
apply_steer = 0
91-
apply_steer_req = 0
92-
elif self.steer_rate_counter > MAX_STEER_RATE_FRAMES:
93-
apply_steer_req = 0
94-
self.steer_rate_counter = 0
81+
# Count up to MAX_STEER_RATE_FRAMES, at which point we need to cut torque to avoid a steering fault
82+
if lat_active and abs(CS.out.steeringRateDeg) >= MAX_STEER_RATE:
83+
self.steer_rate_counter += 1
84+
else:
85+
self.steer_rate_counter = 0
86+
87+
apply_steer_req = 1
88+
if not lat_active:
89+
apply_steer = 0
90+
apply_steer_req = 0
91+
elif self.steer_rate_counter > MAX_STEER_RATE_FRAMES:
92+
apply_steer_req = 0
93+
self.steer_rate_counter = 0
9594

9695
# Never actuate with LKA on cars that only support LTA
9796
if self.CP.steerControlType == car.CarParams.SteerControlType.angle:

0 commit comments

Comments
 (0)