Skip to content

Commit 7a9ffe2

Browse files
authored
chore: fix missing deps + args in dockerfile (#569)
1 parent 3fb7a4f commit 7a9ffe2

File tree

4 files changed

+36767
-11203
lines changed

4 files changed

+36767
-11203
lines changed

Dockerfile

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ ARG BUILD_DATE
33
ARG VCS_REF
44
ARG VERSION
55

6-
76
# web build
87
FROM node:12-alpine as web-build
98
RUN npm i -g npm@8
@@ -12,8 +11,13 @@ WORKDIR /app
1211
COPY ./web/package*.json ./web/yarn.* ./
1312
RUN npm install --legacy-peer-deps
1413
COPY ./web/ ./
15-
RUN npm run build
1614

15+
# FIXME: avoid having those ARGs, make the runtime dynamic.
16+
ARG NODE_ENV=development
17+
ARG API_URL
18+
ARG GITHUB_CLIENT_ID
19+
ARG DEFAULT_TARGETS=moul/depviz-test
20+
RUN GITHUB_CLIENT_ID=$GITHUB_CLIENT_ID API_URL=$API_URL NODE_ENV=$NODE_ENV DEFAULT_TARGETS=$DEFAULT_TARGETS npm run build
1721

1822
# go build
1923
FROM golang:1.19.0-alpine as go-build

0 commit comments

Comments
 (0)