Chrome/m56 #40
Merged
Chrome/m56 #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue was with the A2B0 matrix not being scaled by its encoding factor when it needed to be (for A2B0 matrices only). NOTRY=true NOTREECHECKS=true BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=5003 Change-Id: I3f202323e137e1b014e564bd96d87c601c4748ab Reviewed-on: https://skia-review.googlesource.com/5003 Commit-Queue: Robert Aftias <[email protected]> Reviewed-by: Matt Sarett <[email protected]> Reviewed-on: https://skia-review.googlesource.com/5110
This cherry-pick combines 3 fuzzer-fix CLs: These two rolled into Chrome in https://codereview.chromium.org/2511733006 at 433297 on 11/18 https://skia-review.googlesource.com/c/4961/ (Remove accessRenderTarget call in SkGpuDevice ctor) https://skia-review.googlesource.com/c/4929/ (Guard against instantiate & accessRenderTarget failures) This one rolled into Chrome in https://codereview.chromium.org/2516183002 at 433454 on 11/20 https://skia-review.googlesource.com/c/4991/ (Add handling for instantiate failure up the call stack) Together they address the fuzzer bugs: crbug.com/665681 P1 (Crash in SkSpecialImage_Gpu::onAsTextureRef) crbug.com/665621 P1 (Crash in GrGpuCommandBuffer::draw) crbug.com/665500 P1 (Crash in GrDrawBatch::renderTargetUniqueID) The fuzzer bugs were fixed by the first two patches but the third is going to be necessary too. BUG=665681,665500,665621 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=5081 NOTREECHECKS=true NOTRY=true NOPRESUBMIT=true Change-Id: I3a8b70eae29ac11608e062e66bc26c2208c1dfb3 Reviewed-on: https://skia-review.googlesource.com/5081 Reviewed-by: Brian Salomon <[email protected]> Reviewed-by: Heather Miller <[email protected]> Commit-Queue: Robert Phillips <[email protected]>
Bug(?) in the tetrahedral interpolation causes output values to go out of range a bit (1.035/1.0) in the upper range. We will just clamp for now as a temporary fix. BUG=668784 Change-Id: I78dd90da7174133e647b1c6c6e914dbde5de123c Reviewed-on: https://skia-review.googlesource.com/5228 Reviewed-by: Matt Sarett <[email protected]> Commit-Queue: Robert Aftias <[email protected]> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2535383002 NOTREECHECKS=true NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2535383002
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.