Skip to content

Commit 641970d

Browse files
authored
Drop support of Node v10 (#4633)
1 parent 5064c28 commit 641970d

File tree

4 files changed

+12
-21
lines changed

4 files changed

+12
-21
lines changed

.github/workflows/mocha.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ jobs:
2525
- ubuntu-latest
2626
- windows-2019
2727
node:
28-
- 10
2928
- 12
3029
- 14
3130
- 16
@@ -70,7 +69,6 @@ jobs:
7069
- ubuntu-latest
7170
- windows-2019
7271
node:
73-
- 10
7472
- 12
7573
- 14
7674
- 16

docs/index.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ or as a development dependency for your project:
6464
$ npm install --save-dev mocha
6565
```
6666

67-
> As of v8.0.0, Mocha requires Node.js v10.12.0 or newer.
67+
> As of v9.0.0, Mocha requires Node.js v12.0.0 or newer.
6868
6969
## Getting Started
7070

@@ -116,7 +116,7 @@ $ npm test
116116

117117
## Run Cycle Overview
118118

119-
> Updated for v9.0.0.
119+
> Updated for v8.0.0.
120120
121121
The following is a mid-level outline of Mocha's "flow of execution" when run in Node.js; the "less important" details have been omitted.
122122

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
"test": "./test"
4343
},
4444
"engines": {
45-
"node": ">= 10.12.0"
45+
"node": ">= 12.0.0"
4646
},
4747
"scripts": {
4848
"prepublishOnly": "nps test clean build",

test/integration/parallel.spec.js

Lines changed: 9 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -2,27 +2,20 @@
22

33
const assert = require('assert');
44
const {runMochaJSONAsync} = require('./helpers');
5-
const semver = require('semver');
65

76
describe('parallel run', () => {
87
/**
98
* @see https://github.com/mochajs/mocha/issues/4559
109
*/
1110
it('should allow `import {it} from "mocha"` module syntax', async () => {
12-
if (semver.major(process.version) <= 10) {
13-
console.log(
14-
`[SKIPPED] for node ${process.version} (es module syntax isn't supported on node <= 10)`
15-
);
16-
} else {
17-
const result = await runMochaJSONAsync('parallel/test3.mjs', [
18-
'--parallel',
19-
'--jobs',
20-
'2',
21-
require.resolve('./fixtures/parallel/test1.mjs'),
22-
require.resolve('./fixtures/parallel/test2.mjs')
23-
]);
24-
assert.strictEqual(result.stats.failures, 1);
25-
assert.strictEqual(result.stats.passes, 2);
26-
}
11+
const result = await runMochaJSONAsync('parallel/test3.mjs', [
12+
'--parallel',
13+
'--jobs',
14+
'2',
15+
require.resolve('./fixtures/parallel/test1.mjs'),
16+
require.resolve('./fixtures/parallel/test2.mjs')
17+
]);
18+
assert.strictEqual(result.stats.failures, 1);
19+
assert.strictEqual(result.stats.passes, 2);
2720
});
2821
});

0 commit comments

Comments
 (0)