remove unused helper variant and fix bug

Author: sebffischer

DESCRIPTION

@@ -54,7 +54,6 @@ Collate:
     'crate.R'
     'cross_join.R'
     'dictionary_sugar.R'
-    'dictionary_sugar_safe.R'
     'did_you_mean.R'
     'distinct_values.R'
     'encapsulate.R'

NAMESPACE

@@ -69,13 +69,9 @@ export(deframe)
 export(detect)
 export(dictionary_sugar)
 export(dictionary_sugar_get)
-export(dictionary_sugar_get_safe)
 export(dictionary_sugar_inc_get)
-export(dictionary_sugar_inc_get_safe)
 export(dictionary_sugar_inc_mget)
-export(dictionary_sugar_inc_mget_safe)
 export(dictionary_sugar_mget)
-export(dictionary_sugar_mget_safe)
 export(did_you_mean)
 export(discard)
 export(distinct_values)

NEWS.md

@@ -1,6 +1,7 @@
 # mlr3misc (development version)
 
 * Bugfix: `crate()` is using the correct 'topenv' environment now.
+* Remove the unused 'safe' variants of dictionary getters
 
 # mlr3misc 0.15.1
 

R/dictionary_sugar.R

@@ -75,7 +75,7 @@ dictionary_sugar_get = function(dict, .key, ...) {
       nn = ndots[[i]]
       if (!exists(nn, envir = instance, inherits = FALSE)) {
         stopf("Cannot set argument '%s' for '%s' (not a constructor argument, not a parameter, not a field.%s",
-          nn, class(instance)[1L], did_you_mean(nn, c(constructor_args, param_ids, fields(obj$value))))
+          nn, class(instance)[1L], did_you_mean(nn, c(constructor_args, param_ids, setdiff(names(instance), ".__enclos_env__")))) # nolint
       }
       instance[[nn]] = dots[[i]]
     }