Skip to content

Conversation

@PieGodEX
Copy link

@PieGodEX PieGodEX commented Jul 10, 2024

Right now, the MacOS automatic build fails with ld: unknown options: -force_cpusubtype_ALL while building vorbis. And based on https://trac.macports.org/ticket/68240, this is an issue introduced by Xcode 15 no longer accepting -force_cpusubtype_ALL as a valid flag.

So anyways, this just slaps "use Xcode 14 pls" onto the workflow and calls it a day.

1720624420378__()
Which works, according to my quick tests

Alternate solutions probably exist, like

  • "just downgrade the runner to macos-13"
  • "just remove the flag from the fork", or
  • "just update the vorbis fork since they fixed that on their side by now" (EDIT: never mind no they didn't)

But this is probably the easiest and most future-proof way with the least chance of accidentally affecting something else.

Forces the Mac-os workflow to use Xcode 14, since apparently, according to https://trac.macports.org/ticket/68240 this is an issue now
@Eblo
Copy link

Eblo commented Jul 10, 2024

"just downgrade the runner to `macos-13`"

I think it was actually the macos-13 runner that introduced this, but macos-latest jumped from 12 to 14. Either way, I wouldn't expect older runners to stick around for long.

"just remove the flag from the fork", or

I did this for my own forks. Seems to work fine, though it is a more invasive fix than just updating the CI config.

@Splendide-Imaginarius
Copy link

  • "just update the vorbis fork since they fixed that on their side by now" (EDIT: never mind no they didn't)

Is this build fail arguably a bug in upstream Vorbis?

@Splendide-Imaginarius
Copy link

macOS CI is still failing, though not on vorbis. Not sure what the issue is.

@PieGodEX
Copy link
Author

Is this build fail arguably a bug in upstream Vorbis?

Yeah, and it doesn't look like the bug report there is getting any attention yet

macOS CI is still failing, though not on vorbis. Not sure what the issue is.

And I'm getting that sometimes too recently, last time for me it was with the Ubuntu x86_64 one, in both cases I just deleted the cache file it generated and tried again and it worked, although I still don't get the exact reason why, though

@Splendide-Imaginarius
Copy link

Yeah, and it doesn't look like the bug report there is getting any attention yet

@PieGodEX Can you link to the relevant bug report?

@PieGodEX
Copy link
Author

@PieGodEX Can you link to the relevant bug report?

xiph/vorbis#107 Yeah sure
It recently started getting activity and got a pull request targetting it since then, at least

@Splendide-Imaginarius
Copy link

Looks like the current PR to track is xiph/vorbis#109

I don't plan to do anything on mkxp-z's end until we see where that PR goes.

@PieGodEX
Copy link
Author

Sure that's fine, closing this for now then

@PieGodEX PieGodEX closed this Jul 31, 2024
@Splendide-Imaginarius
Copy link

I'd like to keep this open for tracking purposes so that I don't forget to deal with it later. I'll close it again once mkxp-z actually has working macOS binaries again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants