-
Notifications
You must be signed in to change notification settings - Fork 74
Update mac-os workflow to use Xcode 14 #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Forces the Mac-os workflow to use Xcode 14, since apparently, according to https://trac.macports.org/ticket/68240 this is an issue now
I think it was actually the macos-13 runner that introduced this, but macos-latest jumped from 12 to 14. Either way, I wouldn't expect older runners to stick around for long.
I did this for my own forks. Seems to work fine, though it is a more invasive fix than just updating the CI config. |
Is this build fail arguably a bug in upstream Vorbis? |
|
macOS CI is still failing, though not on vorbis. Not sure what the issue is. |
Yeah, and it doesn't look like the bug report there is getting any attention yet
And I'm getting that sometimes too recently, last time for me it was with the Ubuntu x86_64 one, in both cases I just deleted the cache file it generated and tried again and it worked, although I still don't get the exact reason why, though |
@PieGodEX Can you link to the relevant bug report? |
xiph/vorbis#107 Yeah sure |
Fixes: xiph#107 Fixes: xiph#108 (See also: mkxp-z/mkxp-z#200)
Fixes: xiph#107 Fixes: xiph#108 (See also: mkxp-z/mkxp-z#200)
|
Looks like the current PR to track is xiph/vorbis#109 I don't plan to do anything on mkxp-z's end until we see where that PR goes. |
|
Sure that's fine, closing this for now then |
|
I'd like to keep this open for tracking purposes so that I don't forget to deal with it later. I'll close it again once mkxp-z actually has working macOS binaries again. |
Fixes: xiph#107 Fixes: xiph#108 (See also: mkxp-z/mkxp-z#200)
Fixes: xiph#107 Fixes: xiph#108 (See also: mkxp-z/mkxp-z#200)
Right now, the MacOS automatic build fails with
ld: unknown options: -force_cpusubtype_ALLwhile building vorbis. And based on https://trac.macports.org/ticket/68240, this is an issue introduced by Xcode 15 no longer accepting-force_cpusubtype_ALLas a valid flag.So anyways, this just slaps "use Xcode 14 pls" onto the workflow and calls it a day.
Which works, according to my quick tests
Alternate solutions probably exist, like
macos-13""just update the vorbis fork since they fixed that on their side by now"(EDIT: never mind no they didn't)But this is probably the easiest and most future-proof way with the least chance of accidentally affecting something else.