Skip to content

Commit 45a7503

Browse files
committed
Undo deprecation of connection value
In #798 the connection value has been deprecated with the claim it is useless. However, in fact it is used at least with the Mirage backend in order to track the connections for logging etc. (See last two comments of the PR.) In over 3 years no replacement has been added, so this change removes the deprecation until some alternative exists. (Which could be possibly Mirage only.)
1 parent ca90e54 commit 45a7503

File tree

5 files changed

+5
-5
lines changed

5 files changed

+5
-5
lines changed

cohttp-eio/src/server.ml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ open Utils
22
module IO = Io.IO
33

44
type body = Body.t
5-
type conn = IO.conn * Cohttp.Connection.t [@@warning "-3"]
5+
type conn = IO.conn * Cohttp.Connection.t
66
type writer = Http.Request.t * IO.oc
77
type response = writer -> unit
88

cohttp-lwt/src/server.ml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
open Lwt.Infix
22
module Header = Cohttp.Header
3-
module Connection = Cohttp.Connection [@@warning "-3"]
3+
module Connection = Cohttp.Connection
44

55
module Make (IO : S.IO) = struct
66
module IO = IO

cohttp-mirage/src/static.ml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
*)
1919

2020
module Key = Mirage_kv.Key
21-
module Connection = Cohttp.Connection [@@warning "-3"]
21+
module Connection = Cohttp.Connection
2222

2323
module HTTP (FS : Mirage_kv.RO) (S : Cohttp_lwt.S.Server) = struct
2424
open Lwt.Infix

cohttp/src/cohttp.ml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ module Accept = Accept
22
module Auth = Auth
33
module Body = Body
44
module Conf = Conf
5-
module Connection = Connection [@@deprecated "Connection.t values are useless."]
5+
module Connection = Connection
66
module Code = Code
77
module Cookie = Cookie
88
module Header = Header

cohttp/src/server.ml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ module type S = sig
22
module IO : S.IO
33

44
type body
5-
type conn = IO.conn * Connection.t [@@warning "-3"]
5+
type conn = IO.conn * Connection.t
66
type response
77

88
type response_action =

0 commit comments

Comments
 (0)