Skip to content

Conversation

@XuanYang-cn
Copy link
Contributor

Also optinal variables default value should always be None. And empty str is always invalid variable

See also: #2327
pr: #2350

Also optinal variables default value should always be None.
And empty str is always invalid variable

See also: milvus-io#2327
pr: milvus-io#2350

Signed-off-by: yangxuan <[email protected]>
Signed-off-by: yangxuan <[email protected]>
Signed-off-by: yangxuan <[email protected]>
@czs007
Copy link
Contributor

czs007 commented Nov 25, 2024

/approve
/lgtm

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 26e92ff into milvus-io:2.4 Nov 25, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants