Corrected grammar and consistency in error messages #2289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Ahmetyasin The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Welcome @Ahmetyasin! It looks like this is your first PR to milvus-io/pymilvus 🎉 |
Contributor
|
@Ahmetyasin could you add singed-off? There is one commit incorrectly signed off. This means that the author of this commit failed to include a Signed-off-by line in the commit message. To avoid having PRs blocked in the future, always include Signed-off-by: Author Name [email protected] in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s). |
czs007
pushed a commit
to czs007/pymilvus
that referenced
this pull request
Nov 6, 2024
This PR updates several error messages for grammar and clarity. The changes include: Corrected "data should be a list of list" to "The data should be a list of lists" for better readability. Fixed grammar in "The data don't match with schema fields" to "The data doesn't match with schema fields." Corrected field name mismatch message from "The name of field don't match" to "The name of the field doesn't match." These improvements enhance the clarity and professionalism of error messages in the codebase.
czs007
pushed a commit
to czs007/pymilvus
that referenced
this pull request
Nov 6, 2024
This PR updates several error messages for grammar and clarity. The changes include: Corrected "data should be a list of list" to "The data should be a list of lists" for better readability. Fixed grammar in "The data don't match with schema fields" to "The data doesn't match with schema fields." Corrected field name mismatch message from "The name of field don't match" to "The name of the field doesn't match." These improvements enhance the clarity and professionalism of error messages in the codebase. Signed-off-by: zhenshan.cao <[email protected]> Co-authored-by: Ahmet Yasin Aytar <[email protected]>
Contributor
|
I have picked to branch 2.4 refer to : #2330 |
XuanYang-cn
added
the
PR | cherry-picked to 2.x
sre-ci-robot
pushed a commit
that referenced
this pull request
Nov 7, 2024
This PR updates several error messages for grammar and clarity. The changes include: Corrected "data should be a list of list" to "The data should be a list of lists" for better readability. Fixed grammar in "The data don't match with schema fields" to "The data doesn't match with schema fields." Corrected field name mismatch message from "The name of field don't match" to "The name of the field doesn't match." These improvements enhance the clarity and professionalism of error messages in the codebase. Signed-off-by: zhenshan.cao <[email protected]> Co-authored-by: Ahmet Yasin Aytar <[email protected]>
CaoHaiNam
pushed a commit
to CaoHaiNam/pymilvus
that referenced
this pull request
Nov 7, 2024
This PR updates several error messages for grammar and clarity. The changes include: Corrected "data should be a list of list" to "The data should be a list of lists" for better readability. Fixed grammar in "The data don't match with schema fields" to "The data doesn't match with schema fields." Corrected field name mismatch message from "The name of field don't match" to "The name of the field doesn't match." These improvements enhance the clarity and professionalism of error messages in the codebase. Signed-off-by: NamCaoHai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates several error messages for grammar and clarity. The changes include:
Corrected "data should be a list of list" to "The data should be a list of lists" for better readability.
Fixed grammar in "The data don't match with schema fields" to "The data doesn't match with schema fields."
Corrected field name mismatch message from "The name of field don't match" to "The name of the field doesn't match."
These improvements enhance the clarity and professionalism of error messages in the codebase.