Skip to content

Commit f7a4839

Browse files
authored
enhance: update milvus-proto and correct index.drop() (#2142)
Index name and field name is already there for Index object, No need to get them from kwargs when drop ```python ivf_flat = Index(c, "embeddings", params, index_name="ivf_flat", construct_only=True) ivf_flat.drop() ``` --------- Signed-off-by: yangxuan <[email protected]>
1 parent cddbf61 commit f7a4839

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

.github/mergify.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,12 @@ pull_request_rules:
44
- or:
55
- base=master
66
- base~=2\.\d
7-
- "status-success=Run Python Tests (3.8)"
7+
- "status-success=Run Python Tests (3.8, windows-latest)"
8+
- "status-success=Run Python Tests (3.12, windows-latest)"
9+
- "status-success=Run Python Tests (3.8, ubuntu-latest)"
10+
- "status-success=Run Python Tests (3.12, ubuntu-latest)"
811
- "status-success=Run Check Proto (3.8)"
912
- "status-success=Code lint check (3.8)"
10-
- "status-success=Run Python Tests (3.12)"
1113
- "status-success=Run Check Proto (3.12)"
1214
- "status-success=Code lint check (3.12)"
1315
actions:

pymilvus/orm/index.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -73,10 +73,8 @@ def __init__(
7373
self._collection = collection
7474
self._field_name = field_name
7575
self._index_params = index_params
76-
index_name = kwargs.get("index_name", Config.IndexName)
77-
self._index_name = index_name
78-
self._kwargs = kwargs
79-
if self._kwargs.pop("construct_only", False):
76+
self._index_name = kwargs.get("index_name", Config.IndexName)
77+
if kwargs.get("construct_only", False):
8078
return
8179

8280
conn = self._get_connection()
@@ -137,5 +135,4 @@ def drop(self, timeout: Optional[float] = None, **kwargs):
137135
field_name=self.field_name,
138136
index_name=self.index_name,
139137
timeout=timeout,
140-
**kwargs,
141138
)

0 commit comments

Comments
 (0)