Skip to content

Commit 989ae07

Browse files
authored
Improvement support colab (#1353)
Google colab notebook already installed protobuf==3.20.3 at the moment. And installing grpcio-tools will request a higher version protobuf. So a restart for notebook kernel is needed. Indeed grpcio-tools is not mandatory for pymilvus. Signed-off-by: Ji Bin <[email protected]>
1 parent 046d09a commit 989ae07

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

pymilvus/grpc_gen/python_gen.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
OUTDIR=.
44
PROTO_DIR="milvus-proto/proto"
55

6+
python -m pip install "grpcio-tools==$(python3 -c 'import grpc; print(grpc.__version__)')"
7+
68
python -m grpc_tools.protoc -I ${PROTO_DIR} --python_out=${OUTDIR} --pyi_out=${OUTDIR} ${PROTO_DIR}/common.proto
79
python -m grpc_tools.protoc -I ${PROTO_DIR} --python_out=${OUTDIR} --pyi_out=${OUTDIR} ${PROTO_DIR}/schema.proto
810
python -m grpc_tools.protoc -I ${PROTO_DIR} --python_out=${OUTDIR} --pyi_out=${OUTDIR} --grpc_python_out=${OUTDIR} ${PROTO_DIR}/milvus.proto

setup.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
include_package_data=True,
2121
install_requires=[
2222
"grpcio>=1.49.1,<=1.53.0",
23-
"grpcio-tools>=1.49.1,<=1.53.0",
2423
"mmh3>=2.0",
2524
"ujson>=2.0.0",
2625
"pandas>=1.2.4",

0 commit comments

Comments
 (0)