Skip to content

Commit 7520087

Browse files
authored
enhance: [2.4]Expand grpcio version to latest (#2096)
Signed-off-by: yangxuan <[email protected]>
1 parent 0979edf commit 7520087

File tree

14 files changed

+27
-24
lines changed

14 files changed

+27
-24
lines changed

.github/workflows/check_milvus_proto.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,5 +31,6 @@ jobs:
3131
- name: Try generate proto
3232
run: |
3333
git submodule update --init
34+
make gen_proto
3435
make check_proto_product
3536

.github/workflows/code_checker.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ jobs:
2424
pip install -e .
2525
- name: Install requirements
2626
run: |
27-
pip install -r requirements.txt
27+
pip install -e ".[dev]"
2828
- name: Run pylint
2929
shell: bash
3030
run: |

.github/workflows/pull_request.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ jobs:
2828
- name: Install dependencies
2929
run: |
3030
python -m pip install --upgrade pip
31-
pip install -e ".[test]"
31+
pip install -e ".[dev]"
3232
3333
- name: Test with pytest
3434
run: |

Makefile

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@ unittest:
22
PYTHONPATH=`pwd` python3 -m pytest tests --cov=pymilvus -v
33

44
lint:
5-
PYTHONPATH=`pwd` black pymilvus --check
6-
PYTHONPATH=`pwd` ruff check pymilvus
5+
PYTHONPATH=`pwd` python3 -m black pymilvus --check
6+
PYTHONPATH=`pwd` python3 -m ruff check pymilvus
77

88
format:
9-
PYTHONPATH=`pwd` black pymilvus
10-
PYTHONPATH=`pwd` ruff check pymilvus --fix
9+
PYTHONPATH=`pwd` python3 -m black pymilvus
10+
PYTHONPATH=`pwd` python3 -m ruff check pymilvus --fix
1111

1212
codecov:
1313
PYTHONPATH=`pwd` pytest --cov=pymilvus --cov-report=xml tests -x -v -rxXs
@@ -25,6 +25,7 @@ get_proto:
2525
git submodule update --init
2626

2727
gen_proto:
28+
python3 -m pip install -e ".[dev]"
2829
cd pymilvus/grpc_gen && ./python_gen.sh
2930

3031
check_proto_product: gen_proto

README.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ You can install PyMilvus via `pip` or `pip3` for Python 3.8+:
3737
```shell
3838
$ pip3 install pymilvus
3939
$ pip3 install pymilvus[model] # for milvus-model
40+
$ pip3 install pymilvus[bulk_writer] # for bulk_writer
4041
```
4142

4243
You can install a specific version of PyMilvus by:
@@ -62,8 +63,6 @@ $ git submodule update --init
6263

6364
Q2. How to generate python files from milvus-proto?
6465

65-
**Before generating python files, please install requirements in `requirements.txt`**
66-
6766
A2.
6867
```shell
6968
$ make gen_proto
@@ -94,10 +93,10 @@ Q6. How to run unittests?
9493

9594
A6
9695
```shell
97-
$ pip install ".[test]"
96+
$ pip install ".[dev]"
9897
$ make unittest
9998
```
100-
Q7. `zsh: no matches found: pymilvus[model]` in mac, how do I solve this?
99+
Q7. `zsh: no matches found: pymilvus[model]`, how do I solve this?
101100

102101
A7
103102
```shell

pymilvus/grpc_gen/common_pb2.py

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pymilvus/grpc_gen/feder_pb2.py

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pymilvus/grpc_gen/milvus_pb2.py

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pymilvus/grpc_gen/msg_pb2.py

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pymilvus/grpc_gen/python_gen.sh

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@
33
OUTDIR=.
44
PROTO_DIR="milvus-proto/proto"
55

6-
python -m pip install "grpcio-tools==$(python3 -c 'import grpc; print(grpc.__version__)')"
7-
86
python -m grpc_tools.protoc -I ${PROTO_DIR} --python_out=${OUTDIR} --pyi_out=${OUTDIR} ${PROTO_DIR}/common.proto
97
python -m grpc_tools.protoc -I ${PROTO_DIR} --python_out=${OUTDIR} --pyi_out=${OUTDIR} ${PROTO_DIR}/schema.proto
108
python -m grpc_tools.protoc -I ${PROTO_DIR} --python_out=${OUTDIR} --pyi_out=${OUTDIR} ${PROTO_DIR}/feder.proto

0 commit comments

Comments
 (0)