Skip to content

Commit 21844e9

Browse files
authored
feat: disable installation of milvus-lite on windows platform (#2131) (#2134)
@XuanYang-cn Since the project is managed by setuptools, and according to the [setuptools](https://setuptools.pypa.io/en/latest/userguide/dependency_management.html), we can disable the automatic installation of milvus-lite on windows platform by adding environment markers. Following [PEP508](https://peps.python.org/pep-0508/), I pick the environment marker "sys_platform != 'win32'" to prevent the installation. I build packages after the modification. Then test the .tar.gz and the .whl files both on my windows laptop and a linux docker. The issue mentioned in #2131 seems gone. Due the lack of macOS machine, I could not perform testing on that particular platform. Please check validity before merging. Signed-off-by: rui zhang <[email protected]>
1 parent 02c7472 commit 21844e9

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ dependencies=[
2424
"ujson>=2.0.0",
2525
"pandas>=1.2.4",
2626
"numpy<1.25.0;python_version<='3.8'",
27-
"milvus-lite>=2.4.0",
27+
"milvus-lite>=2.4.0;sys_platform!='win32'",
2828
]
2929

3030
classifiers=[

0 commit comments

Comments
 (0)