Skip to content

Commit 4120301

Browse files
committed
simplify conditions again
1 parent 4120dea commit 4120301

File tree

3 files changed

+14
-15
lines changed

3 files changed

+14
-15
lines changed

dist/index.js

Lines changed: 10 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/index.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/table.ts

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ export function buildSummaryTables(
9393

9494
const annotations = testResult.globalAnnotations.filter(
9595
annotation =>
96-
(includePassed || annotation.annotation_level !== 'notice' || annotation.status !== 'success') &&
96+
(includePassed || annotation.annotation_level !== 'notice') &&
9797
(includeSkipped || annotation.status !== 'skipped')
9898
)
9999

@@ -142,11 +142,7 @@ export function buildSummaryTables(
142142
}
143143

144144
if (flakySummary) {
145-
const flakyAnnotations = annotations.filter(
146-
annotation =>
147-
annotation.retries > 0 &&
148-
(includeSkipped || annotation.status !== 'skipped')
149-
)
145+
const flakyAnnotations = annotations.filter(annotation => annotation.retries > 0)
150146
if (flakyAnnotations.length > 0) {
151147
flakyTable.push([{data: `<strong>${testResult.checkName}</strong>`, colspan}])
152148
for (const annotation of flakyAnnotations) {
@@ -175,7 +171,7 @@ function appendDetailsTable(
175171
const colspan = includeTimeInSummary ? '3' : '2'
176172
const annotations = testResult.annotations.filter(
177173
annotation =>
178-
(includePassed || annotation.annotation_level !== 'notice' || annotation.status !== 'success') &&
174+
(includePassed || annotation.annotation_level !== 'notice') &&
179175
(includeSkipped || annotation.status !== 'skipped')
180176
)
181177
if (annotations.length > 0) {

0 commit comments

Comments
 (0)