Add option to control width of the line cursor

[ramya-rao-a]

#41052

[rebornix]

this._typicalHalfwidthCharacterWidth might change in next block, which makes this._lineCursorWidth out of date.

[ramya-rao-a]

Done

[rebornix]

I would prefer to put this expression still in if blocks to avoid unnecessary line content read

[ramya-rao-a]

Done

[rebornix]

The code looks good to me in general 👍 . IMHO it would be better if we have this option for cursor style block instead of line:

• Right now by definition CursorStyle.Line and LineThin are displaying cursor as a vertical line between characters, while CursorStyle.Block is on top of a character. Adding this options makes the cursor now displays on top of characters (if the width is large), ppl may call it half-width-block cursor or partial-block-cursor
  
• Or maybe we simply call it cursorWidth and apply this to all cursor styles.

update
I started to think about what's the real feature request for wide caret. Doesn't our Block cursor meet their need, or they want half-block-cursor? Or maybe they want to have wide caret for cursor styles other than Line @ramya-rao-a

[ramya-rao-a]

I started to think about what's the real feature request for wide caret. Doesn't our Block cursor meet their need, or they want half-block-cursor? Or maybe they want to have wide caret for cursor styles other than Line

The request is to have a vertical cursor thicker than the current line style but not as wide as the block style.

[alexdima]

Sorry for the late feedback, should we call the option cursorWidth with a default of 0. Then, it would align with the other cursor rendering options cursorBlinking and cursorStyle.

If the default of 0 is untouched, the cursor width is computed as it is before the PR. If a different value is provided, the cursor will be the width (in px) of the provided value.

[ramya-rao-a]

@alexandrudima Done with 17b1aaf