Try/catch the functions that get warnings for deployment (#4479)

Author: nturinski

src/commands/createFunctionApp/stacks/getStackPicks.ts

@@ -300,64 +300,68 @@ export async function getEolWarningMessages(context: ISubscriptionActionContext,
         displayVersion: string | undefined;
     } = { endOfLife: undefined, displayVersion: undefined };
 
-    if (options.isFlex) {
-        const runtime = options.site.functionAppConfig?.runtime?.name;
-        version = options.site.functionAppConfig?.runtime?.version;
-        displayInfo = (await getEOLDate(context, {
-            site: options.site,
-            version: nonNullValue(version),
-            runtime: nonNullValue(runtime) === 'dotnet-isolated' ? 'dotnet' : nonNullValue(runtime),
-            isFlex: true,
-            location: options.site.location
-        })
-        );
-    } else if (options.isLinux) {
-        const linuxFxVersion = options.site.siteConfig?.linuxFxVersion;
-        displayInfo = await getEOLLinuxFxVersion(context, nonNullValue(linuxFxVersion));
-    } else if (options.site.siteConfig) {
-        if (options.site.siteConfig.javaVersion) {
-            displayInfo = (await getEOLDate(context, {
-                site: options.site,
-                version: options.site.siteConfig.javaVersion,
-                runtime: 'java'
-            }));
-        } else if (options.site.siteConfig.powerShellVersion) {
+    try {
+        if (options.isFlex) {
+            const runtime = options.site.functionAppConfig?.runtime?.name;
+            version = options.site.functionAppConfig?.runtime?.version;
             displayInfo = (await getEOLDate(context, {
                 site: options.site,
-                version: options.site.siteConfig.powerShellVersion,
-                runtime: 'powershell'
-            }));
-        } else if (options.site.siteConfig.netFrameworkVersion) {
-            // In order to get the node version, we need to check the app settings
-            let appSettings: StringDictionary | undefined;
-            if (options.client) {
-                appSettings = await options.client.listApplicationSettings();
-            }
-            if (appSettings && appSettings.properties && appSettings.properties['WEBSITE_NODE_DEFAULT_VERSION']) {
+                version: nonNullValue(version),
+                runtime: nonNullValue(runtime) === 'dotnet-isolated' ? 'dotnet' : nonNullValue(runtime),
+                isFlex: true,
+                location: options.site.location
+            })
+            );
+        } else if (options.isLinux) {
+            const linuxFxVersion = options.site.siteConfig?.linuxFxVersion;
+            displayInfo = await getEOLLinuxFxVersion(context, nonNullValue(linuxFxVersion));
+        } else if (options.site.siteConfig) {
+            if (options.site.siteConfig.javaVersion) {
                 displayInfo = (await getEOLDate(context, {
                     site: options.site,
-                    version: appSettings.properties['WEBSITE_NODE_DEFAULT_VERSION'],
-                    runtime: 'node'
+                    version: options.site.siteConfig.javaVersion,
+                    runtime: 'java'
                 }));
-            } else {
+            } else if (options.site.siteConfig.powerShellVersion) {
                 displayInfo = (await getEOLDate(context, {
                     site: options.site,
-                    version: options.site.siteConfig.netFrameworkVersion,
-                    runtime: 'dotnet'
+                    version: options.site.siteConfig.powerShellVersion,
+                    runtime: 'powershell'
                 }));
+            } else if (options.site.siteConfig.netFrameworkVersion) {
+                // In order to get the node version, we need to check the app settings
+                let appSettings: StringDictionary | undefined;
+                if (options.client) {
+                    appSettings = await options.client.listApplicationSettings();
+                }
+                if (appSettings && appSettings.properties && appSettings.properties['WEBSITE_NODE_DEFAULT_VERSION']) {
+                    displayInfo = (await getEOLDate(context, {
+                        site: options.site,
+                        version: appSettings.properties['WEBSITE_NODE_DEFAULT_VERSION'],
+                        runtime: 'node'
+                    }));
+                } else {
+                    displayInfo = (await getEOLDate(context, {
+                        site: options.site,
+                        version: options.site.siteConfig.netFrameworkVersion,
+                        runtime: 'dotnet'
+                    }));
+                }
             }
         }
-    }
 
-    if (displayInfo.endOfLife) {
-        const sixMonthsFromNow = new Date(new Date().setMonth(new Date().getMonth() + 6));
-        isEOL = displayInfo.endOfLife <= new Date();
-        willBeEOL = displayInfo.endOfLife <= sixMonthsFromNow;
-        if (isEOL) {
-            return localize('eolWarning', 'Upgrade to the latest available version as version {0} has reached end-of-life on {1} and is no longer supported.', displayInfo.displayVersion, displayInfo.endOfLife.toLocaleDateString());
-        } else if (willBeEOL) {
-            return localize('willBeEolWarning', 'Upgrade to the latest available version as version {0} will reach end-of-life on {1} and will no longer be supported.', displayInfo.displayVersion, displayInfo.endOfLife.toLocaleDateString());
+        if (displayInfo.endOfLife) {
+            const sixMonthsFromNow = new Date(new Date().setMonth(new Date().getMonth() + 6));
+            isEOL = displayInfo.endOfLife <= new Date();
+            willBeEOL = displayInfo.endOfLife <= sixMonthsFromNow;
+            if (isEOL) {
+                return localize('eolWarning', 'Upgrade to the latest available version as version {0} has reached end-of-life on {1} and is no longer supported.', displayInfo.displayVersion, displayInfo.endOfLife.toLocaleDateString());
+            } else if (willBeEOL) {
+                return localize('willBeEolWarning', 'Upgrade to the latest available version as version {0} will reach end-of-life on {1} and will no longer be supported.', displayInfo.displayVersion, displayInfo.endOfLife.toLocaleDateString());
+            }
         }
+    } catch (error) {
+        // do nothing, we don't want to show an error message if we can't get the EOL date
     }
 
     return '';

src/commands/deploy/getWarningsForConnectionSettings.ts

@@ -20,25 +20,35 @@ export async function getWarningsForConnectionSettings(context: IActionContext,
         node: SlotTreeItem,
         projectPath: string | undefined
     }): Promise<string | undefined> {
+    try {
+        const localSettingsPath = await tryGetLocalSettingsFileNoPrompt(context, options.projectPath);
+        let localSettings: ILocalSettingsJson;
+        try {
+            localSettings = localSettingsPath ? await AzExtFsExtra.readJSON(localSettingsPath) : { Values: {} };
+        } catch (err) {
+            // if we can't read the local settings, just assume it's empty
+            localSettings = { Values: {} };
+        }
 
-    const localSettingsPath = await tryGetLocalSettingsFileNoPrompt(context, options.projectPath);
-    const localSettings: ILocalSettingsJson = localSettingsPath ? await AzExtFsExtra.readJSON(localSettingsPath) : { Values: {} };
-    const localConnectionSettings = await getConnectionSettings(localSettings.Values ?? {});
-    const remoteConnectionSettings = await getConnectionSettings(options.appSettings?.properties ?? {});
+        const localConnectionSettings = await getConnectionSettings(localSettings.Values ?? {});
+        const remoteConnectionSettings = await getConnectionSettings(options.appSettings?.properties ?? {});
 
-    if (localConnectionSettings.some(setting => setting.type === 'ManagedIdentity')) {
-        if (!options.node.site.rawSite.identity ||
-            options.node.site.rawSite.identity.type === 'None') {
-            // if they have nothing in remote, warn them to connect a managed identity
-            return localize('configureManagedIdentityWarning',
-                'Your app is not connected to a managed identity. To ensure access, please configure a managed identity. Without it, your application may encounter authorization issues.');
+        if (localConnectionSettings.some(setting => setting.type === 'ManagedIdentity')) {
+            if (!options.node.site.rawSite.identity ||
+                options.node.site.rawSite.identity.type === 'None') {
+                // if they have nothing in remote, warn them to connect a managed identity
+                return localize('configureManagedIdentityWarning',
+                    'Your app is not connected to a managed identity. To ensure access, please configure a managed identity. Without it, your application may encounter authorization issues.');
+            }
         }
-    }
 
-    if (localConnectionSettings.some(setting => setting.type === 'ConnectionString') || remoteConnectionSettings.some(setting => setting.type === 'ConnectionString')) {
-        // if they have connection strings, warn them about insecure connections but don't try to convert them
-        return localize('connectionStringWarning',
-            'Your app may be using connection strings for authentication. This may expose sensitive credentials and lead to security vulnerabilities. Consider using managed identities to enhance security.')
+        if (localConnectionSettings.some(setting => setting.type === 'ConnectionString') || remoteConnectionSettings.some(setting => setting.type === 'ConnectionString')) {
+            // if they have connection strings, warn them about insecure connections but don't try to convert them
+            return localize('connectionStringWarning',
+                'Your app may be using connection strings for authentication. This may expose sensitive credentials and lead to security vulnerabilities. Consider using managed identities to enhance security.')
+        }
+    } catch (err) {
+        // if we can't read local or remote settings, don't warn them about anything
     }
 
     return;