Skip to content

Commit cd4b4f1

Browse files
authored
feat: upgrade minimatch to v10.0.3 (#5291)
* feat: upgrade minimatch to v10.0.3 - Update minimatch dependency from ~3.0.3 to 10.0.3 across monorepo - Update @types/minimatch from 3.0.5 to 6.0.0 - Fix breaking API changes: switch from default import to named import - api-extractor: `import minimatch from 'minimatch'` → `import { minimatch } from 'minimatch'` - webpack4-localization-plugin: same import pattern update - Centralize version management via common-versions.json preferredVersions - Update lock files and repo state hashes for both subspaces Breaking change: minimatch v10 uses named exports instead of default export * add change log * update lock file * chore: remove @types/minimatch * fix: update IMinimatch interface to Minimatch class in package-extractor - minimatch v10 renamed IMinimatch interface to Minimatch class - Update type annotations to use the new class name --------- Co-authored-by: Rob De Feo <[email protected]>
1 parent 78b5b1a commit cd4b4f1

File tree

14 files changed

+135
-97
lines changed

14 files changed

+135
-97
lines changed

apps/api-extractor/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
"@rushstack/terminal": "workspace:*",
4646
"@rushstack/ts-command-line": "workspace:*",
4747
"lodash": "~4.17.15",
48-
"minimatch": "~3.0.3",
48+
"minimatch": "10.0.3",
4949
"resolve": "~1.22.1",
5050
"semver": "~7.5.4",
5151
"source-map": "~0.6.1",
@@ -54,7 +54,6 @@
5454
"devDependencies": {
5555
"@rushstack/heft": "0.74.1",
5656
"@types/lodash": "4.14.116",
57-
"@types/minimatch": "3.0.5",
5857
"@types/resolve": "1.20.2",
5958
"@types/semver": "7.5.0",
6059
"decoupled-local-node-rig": "workspace:*",

apps/api-extractor/src/collector/Collector.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import {
1111
PackageName
1212
} from '@rushstack/node-core-library';
1313
import { ReleaseTag } from '@microsoft/api-extractor-model';
14-
import minimatch from 'minimatch';
14+
import { minimatch } from 'minimatch';
1515

1616
import { ExtractorMessageId } from '../api/ExtractorMessageId';
1717

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
{
2+
"changes": [
3+
{
4+
"packageName": "@microsoft/api-extractor",
5+
"comment": "Upgrades the minimatch dependency from ~3.0.3 to 10.0.3 across the entire Rush monorepo to address a Regular Expression Denial of Service (ReDoS) vulnerability in the underlying brace-expansion dependency.",
6+
"type": "patch"
7+
}
8+
],
9+
"packageName": "@microsoft/api-extractor"
10+
}
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
{
2+
"changes": [
3+
{
4+
"packageName": "@rushstack/package-extractor",
5+
"comment": "Upgrades the minimatch dependency from ~3.0.3 to 10.0.3 across the entire Rush monorepo to address a Regular Expression Denial of Service (ReDoS) vulnerability in the underlying brace-expansion dependency.",
6+
"type": "patch"
7+
}
8+
],
9+
"packageName": "@rushstack/package-extractor"
10+
}
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
{
2+
"changes": [
3+
{
4+
"packageName": "@rushstack/webpack4-localization-plugin",
5+
"comment": "Upgrades the minimatch dependency from ~3.0.3 to 10.0.3 across the entire Rush monorepo to address a Regular Expression Denial of Service (ReDoS) vulnerability in the underlying brace-expansion dependency.",
6+
"type": "patch"
7+
}
8+
],
9+
"packageName": "@rushstack/webpack4-localization-plugin"
10+
}

common/config/subspaces/build-tests-subspace/pnpm-lock.yaml

Lines changed: 16 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
// DO NOT MODIFY THIS FILE MANUALLY BUT DO COMMIT IT. It is generated and used by Rush.
22
{
3-
"pnpmShrinkwrapHash": "4bb96db65ecb99ad3935e230ad704251a845e134",
3+
"pnpmShrinkwrapHash": "05243847c45ec913c83e0cb41b32a208240813a6",
44
"preferredVersionsHash": "550b4cee0bef4e97db6c6aad726df5149d20e7d9",
5-
"packageJsonInjectedDependenciesHash": "6988efb70a621746799ba9bb6049c05da8fa6752"
5+
"packageJsonInjectedDependenciesHash": "d69fad25449ad576c80f4959f15d9b087083c579"
66
}

common/config/subspaces/default/common-versions.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,10 @@
3232
"typescript": "~5.8.2",
3333

3434
// This should be the ESLint version that's used to build most of the projects in the repo.
35-
"eslint": "~9.25.1"
35+
"eslint": "~9.25.1",
36+
37+
// Updated minimatch and its types to latest major version to resolve ReDoS vulnerability
38+
"minimatch": "10.0.3"
3639
},
3740

3841
/**

0 commit comments

Comments
 (0)