Skip to content

Commit b991978

Browse files
committed
[fabric] Fix build warnings
1 parent 933a585 commit b991978

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

packages/react-native/Libraries/Text/TextInput/Singleline/RCTUITextField.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ NS_ASSUME_NONNULL_BEGIN
4545
#if !TARGET_OS_OSX // [macOS]
4646
@property (nonatomic, assign, getter=isEditable) BOOL editable;
4747
#else // [macOS
48-
@property (assign, getter=isEditable) BOOL editable;
48+
@property (atomic, assign, getter=isEditable) BOOL editable;
4949
#endif // macOS]
5050
@property (nonatomic, getter=isScrollEnabled) BOOL scrollEnabled;
5151
@property (nonatomic, strong, nullable) NSString *inputAccessoryViewID;
@@ -56,7 +56,7 @@ NS_ASSUME_NONNULL_BEGIN
5656
#if TARGET_OS_OSX // [macOS
5757
@property (nonatomic, copy, nullable) NSString *text;
5858
@property (nonatomic, copy, nullable) NSAttributedString *attributedText;
59-
@property (nonatomic, copy) NSDictionary<NSAttributedStringKey, id> *defaultTextAttributes;
59+
@property (nonatomic, strong, nullable) NSDictionary<NSAttributedStringKey, id> *defaultTextAttributes;
6060
@property (nonatomic, assign) NSTextAlignment textAlignment;
6161
@property (nonatomic, getter=isAutomaticTextReplacementEnabled) BOOL automaticTextReplacementEnabled;
6262
@property (nonatomic, getter=isAutomaticSpellingCorrectionEnabled) BOOL automaticSpellingCorrectionEnabled;

packages/react-native/React/Fabric/Mounting/ComponentViews/Text/RCTParagraphComponentView.mm

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -50,17 +50,12 @@ - (BOOL)resignFirstResponder
5050
return [super resignFirstResponder];
5151
}
5252

53-
@end
54-
55-
@interface RCTParagraphComponentView () <NSTextViewDelegate>
5653
@end
5754
#endif // macOS]
5855

5956
#if !TARGET_OS_OSX // [macOS]
6057
@interface RCTParagraphComponentView () <UIEditMenuInteractionDelegate>
61-
6258
@property (nonatomic, nullable) UIEditMenuInteraction *editMenuInteraction API_AVAILABLE(ios(16.0));
63-
6459
@end
6560

6661
@implementation RCTParagraphComponentView {
@@ -72,6 +67,9 @@ @implementation RCTParagraphComponentView {
7267
CAShapeLayer *_highlightLayer;
7368
}
7469
#else // [macOS
70+
@interface RCTParagraphComponentView () <NSTextViewDelegate>
71+
@end
72+
7573
@implementation RCTParagraphComponentView {
7674
ParagraphShadowNode::ConcreteState::Shared _state;
7775
ParagraphAttributes _paragraphAttributes;

0 commit comments

Comments
 (0)