Skip to content

Commit e15fc08

Browse files
authored
chore: migrate node types to 10.17.17 (#1690)
1 parent becf97f commit e15fc08

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@
5858
"@types/debug": "0.0.31",
5959
"@types/extract-zip": "^1.6.2",
6060
"@types/mime": "^2.0.1",
61-
"@types/node": "^8.10.34",
61+
"@types/node": "^10.17.17",
6262
"@types/pngjs": "^3.4.0",
6363
"@types/proxy-from-env": "^1.0.0",
6464
"@types/rimraf": "^2.0.2",

src/server/chromium.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,8 @@ export class Chromium implements BrowserType<CRBrowser> {
128128

129129
let transport: PipeTransport | undefined = undefined;
130130
let browserServer: BrowserServer | undefined = undefined;
131-
transport = new PipeTransport(launchedProcess.stdio[3] as NodeJS.WritableStream, launchedProcess.stdio[4] as NodeJS.ReadableStream);
131+
const stdio = launchedProcess.stdio as unknown as [NodeJS.ReadableStream, NodeJS.WritableStream, NodeJS.WritableStream, NodeJS.WritableStream, NodeJS.ReadableStream];
132+
transport = new PipeTransport(stdio[3], stdio[4]);
132133
browserServer = new BrowserServer(launchedProcess, gracefullyClose, launchType === 'server' ? wrapTransportWithWebSocket(transport, port) : null);
133134
return { browserServer, transport, downloadsPath };
134135
}

src/server/webkit.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,8 @@ export class WebKit implements BrowserType<WKBrowser> {
128128
// For local launch scenario close will terminate the browser process.
129129
let transport: ConnectionTransport | undefined = undefined;
130130
let browserServer: BrowserServer | undefined = undefined;
131-
transport = new PipeTransport(launchedProcess.stdio[3] as NodeJS.WritableStream, launchedProcess.stdio[4] as NodeJS.ReadableStream);
131+
const stdio = launchedProcess.stdio as unknown as [NodeJS.ReadableStream, NodeJS.WritableStream, NodeJS.WritableStream, NodeJS.WritableStream, NodeJS.ReadableStream];
132+
transport = new PipeTransport(stdio[3], stdio[4]);
132133
browserServer = new BrowserServer(launchedProcess, gracefullyClose, launchType === 'server' ? wrapTransportWithWebSocket(transport, port || 0) : null);
133134
return { browserServer, transport, downloadsPath };
134135
}

0 commit comments

Comments
 (0)