Improvement to equals in SQLServerDataTable #2653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
ADO run: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2653 +/- ##
============================================
- Coverage 51.75% 51.57% -0.18%
+ Complexity 4050 4004 -46
============================================
Files 147 147
Lines 33781 33782 +1
Branches 5647 5647
============================================
- Hits 17482 17424 -58
- Misses 13880 13901 +21
- Partials 2419 2457 +38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Should I close #2620 then? |
machavan
previously approved these changes
May 8, 2025
divang
previously approved these changes
May 8, 2025
machavan
approved these changes
May 12, 2025
divang
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that it was using == on strings in the equals function for SQLServerDataTable. (I didn't experience a bug as a result of it) Is it intended to check the memory location?