Skip to content

Feature | Cleanup Always Encrypted with secure enclaves tests #1262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 34 commits into from
Apr 15, 2020
Merged

Feature | Cleanup Always Encrypted with secure enclaves tests #1262

merged 34 commits into from
Apr 15, 2020

Conversation

@rene-ye
Copy link
Member

@rene-ye rene-ye commented Feb 13, 2020 •
edited
Loading

Driver changes:
Changed logic to write '0' instead of writing a byte array of '0' when attempting to pad BigIntegers that are not exactly 48 bytes in size.

Test Changes:
Removed duplicate tests from EnclaveTests that are covered in JDBCEncryptionDecryption.
Removed unnecessary server calls to check the state of AE.
Removed unnecessary setup calls in CallableStatement.
Added Enclave computation tests for:

  • String compares with "LIKE"
  • Numeric compares with " = "
  • On the spot column decryption with "ALTER"

Added a negative test which creates an encrypted table and attempts to perform AEv2 operations with a connection without AEv2 enabled.

lilgreenbird and others added 18 commits February 5, 2020 11:03
@lilgreenbird
Fix AEv2 tests exclude for reqExternalSetup and cleanup (microsoft#1247)
c97b863
@lilgreenbird
skip AKV test properly
931158f
@lilgreenbird
removed enclave properties string to failed errors as enclave tests c…
397d3e8 
…ould be skipped
@peterbae
Fix | Add null check for getObject() with LocalTime and LocalDate (mi…
54b5a19 
…crosoft#1250)
@lilgreenbird
added all AKV tests to use reqExternalSetup tag so they will be skipp…
672b7d6 
…ed by default (microsoft#1254)

* skip AKV test properly

* removed enclave properties string to failed errors as enclave tests could be skipped
@rene-ye
Optimize callablestatement test
08d8ae3
@rene-ye
stop checking AE all the time, also add some tags
7c67ebd
@rene-ye
some changes
62d2e64
@rene-ye
test
e05c67e
@rene-ye
Revert "test"
8979de2 
This reverts commit e05c67e.
@rene-ye
Revert "some changes"
89609f8 
This reverts commit 62d2e64.
@rene-ye
delete everythign
2f048f3
@rene-ye
add aev2 stuff
80013a3
@rene-ye
fix index out of bounds
ff33988
@rene-ye
Merge branch 'dev' of https://github.com/Microsoft/mssql-jdbc into junit
1ce8158 
# Conflicts:
#	src/test/java/com/microsoft/sqlserver/jdbc/AlwaysEncrypted/AESetup.java
#	src/test/java/com/microsoft/sqlserver/jdbc/AlwaysEncrypted/EnclaveTest.java
#	src/test/java/com/microsoft/sqlserver/jdbc/AlwaysEncrypted/JDBCEncryptionDecryptionTest.java
@rene-ye
fix errors
4793f81
@rene-ye
Remove test that doesn't belong
67aa997
@rene-ye
revert surefire plugin
8d6f6a5
@codecov-io
Copy link

codecov-io commented Feb 14, 2020 •
edited
Loading

Codecov Report

Merging #1262 into dev will increase coverage by 3.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1262      +/-   ##
============================================
+ Coverage     52.95%   56.07%   +3.12%     
- Complexity     3492     3704     +212     
============================================
  Files           133      133              
  Lines         30096    30096              
  Branches       4979     4979              
============================================
+ Hits          15936    16876     +940     
+ Misses        11870    10840    -1030     
- Partials       2290     2380      +90
Impacted Files Coverage Δ Complexity Δ
...soft/sqlserver/jdbc/ISQLServerEnclaveProvider.java 80.61% <100.00%> (+80.61%) 14.00 <0.00> (+14.00)
...soft/sqlserver/jdbc/SQLServerCertificateUtils.java 0.00% <0.00%> (-81.40%) 0.00% <0.00%> (-22.00%)
...ft/sqlserver/jdbc/SQLServerBouncyCastleLoader.java 0.00% <0.00%> (-80.00%) 0.00% <0.00%> (-2.00%)
.../com/microsoft/sqlserver/jdbc/SqlFedAuthToken.java 0.00% <0.00%> (-40.00%) 0.00% <0.00%> (-1.00%)
...m/microsoft/sqlserver/jdbc/KeyVaultCredential.java 65.11% <0.00%> (-16.28%) 4.00% <0.00%> (ø%)
...osoft/sqlserver/jdbc/SQLServerSecurityUtility.java 26.70% <0.00%> (-14.29%) 12.00% <0.00%> (ø%)
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 43.95% <0.00%> (-3.30%) 15.00% <0.00%> (ø%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 61.82% <0.00%> (-1.38%) 0.00% <0.00%> (ø%)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 46.80% <0.00%> (-1.25%) 120.00% <0.00%> (-1.00%)
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 38.79% <0.00%> (-0.44%) 43.00% <0.00%> (-1.00%)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c25da5...3c25da5. Read the comment docs.

@ulvii ulvii changed the title Junit changes to run tests faster Feature | Cleanup Always Encrypted with secure enclaves tests Feb 14, 2020
@ulvii ulvii added this to the 8.2.2 milestone Feb 27, 2020
peterbae
peterbae reviewed Mar 23, 2020
View reviewed changes
@ulvii ulvii removed this from the 8.3.0 milestone Mar 23, 2020
rene-ye and others added 4 commits April 2, 2020 13:11
@rene-ye
Merge branch 'dev' of https://github.com/microsoft/mssql-jdbc into junit
abc42ed 
# Conflicts:
#	pom.xml
#	src/test/java/com/microsoft/sqlserver/jdbc/AlwaysEncrypted/AESetup.java
#	src/test/java/com/microsoft/sqlserver/jdbc/AlwaysEncrypted/CallableStatementTest.java
#	src/test/java/com/microsoft/sqlserver/jdbc/AlwaysEncrypted/EnclaveTest.java
#	src/test/java/com/microsoft/sqlserver/jdbc/AlwaysEncrypted/JDBCEncryptionDecryptionTest.java
@rene-ye
revert table creation logic
f70a0b2
@rene-ye
fixes
0437d1c
@rene-ye
alter
0c0726b
peterbae
peterbae previously approved these changes Apr 14, 2020
View reviewed changes
lilgreenbird
lilgreenbird previously approved these changes Apr 15, 2020
View reviewed changes
@rene-ye rene-ye merged commit a6da1ae into microsoft:dev Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@ulvii ulvii ulvii approved these changes

@lilgreenbird lilgreenbird lilgreenbird left review comments

@peterbae peterbae peterbae left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rene-ye @codecov-io @lilgreenbird @ulvii @peterbae