Fixed failures in ClientCertificateAuthenticationTest cases (#2796)

Updated test cases for client certificate authentication to include tests for encryption settings and validation of connection states.

Author: muskan124947

src/test/java/com/microsoft/sqlserver/jdbc/clientcertauth/ClientCertificateAuthenticationTest.java

@@ -4,6 +4,7 @@
  */
 package com.microsoft.sqlserver.jdbc.clientcertauth;
 
+import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertTrue;
 
 import java.sql.Connection;
@@ -26,8 +27,8 @@
 
 
 /**
- * Tests client certificate authentication feature
- * The feature is only supported against SQL Server Linux CU2 or higher.
+ * Tests client certificate authentication feature. The feature is only supported against SQL Server Linux CU2 or
+ * higher.
  * 
  */
 @RunWith(JUnitPlatform.class)
@@ -52,8 +53,8 @@ public class ClientCertificateAuthenticationTest extends AbstractTest {
 
     @BeforeAll
     public static void setupTests() throws Exception {
-        //Turn off default encrypt true
-        connectionString = TestUtils.addOrOverrideProperty(connectionString,"encrypt", "false");
+        // Turn off default encrypt true
+        connectionString = TestUtils.addOrOverrideProperty(connectionString, "encrypt", "false");
         setConnection();
     }
 
@@ -207,32 +208,31 @@ public void testDataSource() throws Exception {
      * @throws Exception
      */
     @Test
-    public void testEncryptTrusted() throws Exception {
+    public void testEncryptOn() throws Exception {
         String conStr = connectionString + ";clientCertificate=" + clientCertificate + PEM_SUFFIX + "clientKey="
                 + clientKey + PKCS8_KEY_SUFFIX + "encrypt=true;trustServerCertificate=true;";
-        try (Connection conn = DriverManager.getConnection(conStr); Statement stmt = conn.createStatement()) {
-            ResultSet rs = stmt
-                    .executeQuery("SELECT encrypt_option FROM sys.dm_exec_connections WHERE session_id = @@SPID");
+        try (Connection conn = DriverManager.getConnection(conStr); Statement stmt = conn.createStatement();
+                ResultSet rs = stmt
+                        .executeQuery("SELECT encrypt_option FROM sys.dm_exec_connections WHERE session_id = @@SPID")) {
             rs.next();
             assertTrue(rs.getBoolean(1));
         }
     }
 
     /**
-     * Tests client certificate authentication feature with encryption turned on, untrusted.
+     * Tests client certificate authentication feature with encryption turned off.
      * 
      * @throws Exception
      */
     @Test
-    public void testEncryptUntrusted() throws Exception {
+    public void testEncryptOff() throws Exception {
         String conStr = connectionString + ";clientCertificate=" + clientCertificate + PEM_SUFFIX + "clientKey="
-                + clientKey + PKCS8_KEY_SUFFIX + "encrypt=true;trustServerCertificate=false;trustStore="
-                + trustStorePath;
-        try (Connection conn = DriverManager.getConnection(conStr); Statement stmt = conn.createStatement()) {
-            ResultSet rs = stmt
-                    .executeQuery("SELECT encrypt_option FROM sys.dm_exec_connections WHERE session_id = @@SPID");
+                + clientKey + PKCS8_KEY_SUFFIX + "encrypt=false;trustServerCertificate=true";
+        try (Connection conn = DriverManager.getConnection(conStr); Statement stmt = conn.createStatement();
+                ResultSet rs = stmt
+                        .executeQuery("SELECT encrypt_option FROM sys.dm_exec_connections WHERE session_id = @@SPID")) {
             rs.next();
-            assertTrue(rs.getBoolean(1));
+            assertFalse(rs.getBoolean(1));
         }
     }
 }