Update SensitiveDataLogger for dual environment support #865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified EnsureDevelopmentEnvironment to check DOTNET_ENVIRONMENT if ASPNETCORE_ENVIRONMENT is not set, and updated exception message. Updated SensitiveDataLoggerTests.cs to distinguish between environment variables. Added new test methods for different environments. Renamed existing test methods for clarity. Updated Dispose method to clear both environment variables.
dluc
reviewed
Oct 28, 2024
service/tests/Abstractions.UnitTests/Diagnostics/SensitiveDataLoggerTests.cs
Outdated
Show resolved
Hide resolved
dluc
reviewed
Oct 28, 2024
service/tests/Abstractions.UnitTests/Diagnostics/SensitiveDataLoggerTests.cs
Outdated
Show resolved
Hide resolved
…LoggerTests.cs Added tests also for the opposite scenario
dluc
force-pushed
the
dotnet_environment
branch
from
fe3e0ca to
5d303ef
Compare
dluc
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified
EnsureDevelopmentEnvironmentto checkDOTNET_ENVIRONMENTifASPNETCORE_ENVIRONMENTis not set, and updated exception message. Updated SensitiveDataLoggerTests.cs to distinguish between environment variables. Added new test methods for different environments. Renamed existing test methods for clarity. UpdatedDisposemethod to clear both environment variables.Motivation and Context (Why the change? What's the scenario?)
See https://github.com/microsoft/kernel-memory/issues/851