-
Notifications
You must be signed in to change notification settings - Fork 396
Unit tests for the SensitiveDataLogger #853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
These unit tests provide coverage for the problem raised in #851 |
|
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes for readability and to handle string case. Fixed Dispose.
One thing I would improve is making sure tests do not run in parallel, because they act on shared state, e.g. the static .Enabled and the env var. I tried adding an
Assert.False(SensitiveDataLogger.Enabled);
at the start of each test.
Motivation and Context (Why the change? What's the scenario?)
Contributing unit tests for the
SensitiveDataLoggerto cover a recently fixed bug and prevent future regression.High level description (Approach, Design)
N/A - unit tests only