File tree Expand file tree Collapse file tree 1 file changed +17
-2
lines changed Expand file tree Collapse file tree 1 file changed +17
-2
lines changed Original file line number Diff line number Diff line change @@ -152,8 +152,23 @@ protected static string GetEmbeddingProviderName(object generator)
152152
153153 protected static string GetEmbeddingGeneratorName ( object generator )
154154 {
155- // TODO: use the model name
156- return "TODO" ;
155+ /* @todo Embedding cache
156+ *
157+ * The orchestrator is caching embeddings, and the cache key would be composed by:
158+ *
159+ * 1. the generator class name (see GetEmbeddingProviderName)
160+ * 2. the model used
161+ *
162+ * Embedding generators do not expose the model in use though, so we're using a
163+ * temporary placeholder.
164+ *
165+ * Work to do: remove embedding cache from the pipeline and leave it to embedding
166+ * generators to cache (dev branch: embeddingcache), so that all clients and handlers
167+ * will benefit. This approach removes also the need for generators to expose
168+ * internal details.
169+ */
170+
171+ return "__" ;
157172 }
158173
159174 protected class PartitionInfo (
You can’t perform that action at this time.
0 commit comments