Skip to content

Commit 79962a7

Browse files
authored
fix: fix some minor bugs in qlib scenario (#817)
* fix some bugs * fix a bug * fix a bug in qlib frontend * fix ci * fic ci * fix qlib Dockerfile
1 parent a8c6a20 commit 79962a7

File tree

5 files changed

+21
-8
lines changed

5 files changed

+21
-8
lines changed

rdagent/components/coder/CoSTEER/evaluators.py

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,21 +114,35 @@ def __init__(
114114
# Instead, we should create subclass for it.
115115
self.shape_feedback = shape_feedback # Not general enough. So
116116

117-
# TODO: @property
118117
@property
119118
def execution(self):
120119
return self.execution_feedback
121120

121+
@execution.setter
122+
def execution(self, value):
123+
self.execution_feedback = value
124+
122125
@property
123126
def return_checking(self):
124127
if self.value_generated_flag:
125128
return f"value feedback: {self.value_feedback}\n\nshape feedback: {self.shape_feedback}"
126129
return None
127130

131+
@return_checking.setter
132+
def return_checking(self, value):
133+
# Since return_checking is derived from value_feedback and shape_feedback,
134+
# we don't need to do anything here
135+
self.value_feedback = value
136+
self.shape_feedback = value
137+
128138
@property
129139
def code(self):
130140
return self.code_feedback
131141

142+
@code.setter
143+
def code(self, value):
144+
self.code_feedback = value
145+
132146
def __str__(self) -> str:
133147
return f"""------------------Execution Feedback------------------
134148
{self.execution_feedback if self.execution_feedback is not None else 'No execution feedback'}

rdagent/components/coder/factor_coder/__init__.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ def develop(self, exp: Experiment) -> Experiment:
2626
try:
2727
exp = super().develop(exp)
2828
finally:
29-
es = self.evolve_agent.evolving_trace[-1]
30-
exp.prop_dev_feedback = es.feedback
29+
if hasattr(self, "evolve_agent") and self.evolve_agent.evolving_trace:
30+
es = self.evolve_agent.evolving_trace[-1]
31+
exp.prop_dev_feedback = es.feedback
3132
return exp

rdagent/log/ui/app.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -210,10 +210,7 @@ def get_msgs_until(end_func: Callable[[Message], bool] = lambda _: True):
210210
msg.content = [i for i in msg.content if i]
211211
if "evolving feedback" in tags:
212212
total_len = len(msg.content)
213-
msg.content = [i for i in msg.content if i]
214213
none_num = total_len - len(msg.content)
215-
if len(msg.content) != len(state.msgs[state.lround]["d.evolving code"][-1].content):
216-
st.toast(":red[**Evolving Feedback Length Error!**]", icon="‼️")
217214
right_num = 0
218215
for wsf in msg.content:
219216
if wsf.final_decision:

rdagent/scenarios/qlib/docker/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,11 @@ RUN apt-get clean && apt-get update && apt-get install -y \
99
build-essential \
1010
&& rm -rf /var/lib/apt/lists/*
1111

12-
RUN git clone --depth=100 https://github.com/microsoft/qlib.git
12+
RUN git clone https://github.com/microsoft/qlib.git
1313

1414
WORKDIR /workspace/qlib
1515

16-
RUN git reset e7a1b5ea1ff4412792eeb606a639e0dde422053a --hard
16+
RUN git fetch && git reset dbde1a109fb53e742a4dd210552ebf943576add9 --hard
1717

1818
RUN python -m pip install --upgrade cython
1919
RUN python -m pip install -e .

rdagent/utils/env.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -443,6 +443,7 @@ class QlibDockerConf(DockerConf):
443443
extra_volumes: dict = {str(Path("~/.qlib/").expanduser().resolve().absolute()): "/root/.qlib/"}
444444
shm_size: str | None = "16g"
445445
enable_gpu: bool = True
446+
enable_cache: bool = False
446447

447448

448449
class DMDockerConf(DockerConf):

0 commit comments

Comments
 (0)