Adding array operator long vector tests to HLK #7887
Draft
+131
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
damyanp
reviewed
Nov 10, 2025
Comment on lines
67
to
70
| OP_DEFAULT_DEFINES(ArrayOperator, ArrayOperator_Loop, 2, "TestArrayOperatorLoop", "", | ||
| " -DFUNC_ARRAY_OPERATOR=1 -DLOOP_ATTRB=loop") | ||
| OP_DEFAULT_DEFINES(ArrayOperator, ArrayOperator_Unroll, 2, "TestArrayOperatorUnroll", "", | ||
| " -DFUNC_ARRAY_OPERATOR=1 -DLOOP_ATTRB=unroll") |
Member
There was a problem hiding this comment.
Did you consider doing the loop / unroll versions as a single "OP"? For the expected results instead of using size * 2 you could use size * 4 and in the shader just have the loops one after another?
damyanp
reviewed
Nov 10, 2025
Comment on lines
4140
to
4144
| [LOOP_ATTRB] for(uint i = 0; i < OutNum; i++) | ||
| OutputVector[i] = Input1[i] + Input2[i]; | ||
| [LOOP_ATTRB] for(uint i = 0; i < OutNum; i++) | ||
| g_OutputVector.Store<OUT_TYPE>(sizeof(OUT_TYPE) * (OutNum + i), OutputVector[i]); |
Member
There was a problem hiding this comment.
It's not obvious to me why there are two loops here? Are they testing different dxil ops? A comment to explain this might help.
damyanp
reviewed
Nov 10, 2025
Comment on lines
4133
to
4135
| vector<OUT_TYPE, OutNum> OutputVector = g_InputVector1.Load< vector<TYPE, | ||
| NUM> >(0); | ||
| OutputVector[0] = Input1[OutNum - 1]; |
Member
There was a problem hiding this comment.
Is there some auto formatter or something that puts this awkward line break here?
Suggested change
| vector<OUT_TYPE, OutNum> OutputVector = g_InputVector1.Load< vector<TYPE, | |
| NUM> >(0); | |
| OutputVector[0] = Input1[OutNum - 1]; | |
| vector<OUT_TYPE, OutNum> OutputVector = g_InputVector1.Load< vector<TYPE, NUM> >(0); | |
| OutputVector[0] = Input1[OutNum - 1]; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is adding array operator long vector test to HLK. There are 3 scenarios that were identified when doing those tests:
shufflevectorto order the array in the correct new order.extracelementandinsertelementto perform loads and stores.Closes: #7618