Skip to content

Commit 963f0f6

Browse files
authored
Try Fix Launching with non-Ascii characters in path to Language Server (#688)
* Try to fix handling of non-ascii characters Per report in #687, try to fix proper handling of non-ascii characters in path to server modules * Fix capitalization in tsconfig* Refine pack-ext task definition * Run Npm Audit fix * Update Changelog.md
1 parent 3237407 commit 963f0f6

File tree

5 files changed

+2448
-461
lines changed

5 files changed

+2448
-461
lines changed

Changelog.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,13 @@ All notable changes to this project will be documented in this file.
44
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
55
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
66

7+
## [1.0.57] - 2025-05-28
8+
## Fix
9+
Fix an issue handling non-ascii paths when launching LSP in VS Code Extension
10+
11+
## Dependencies
12+
Update Dependencies
13+
714
## [1.0.56] - 2025-04-14
815
## Tests
916
Migrate to MTP

DevSkim-VSCode-Plugin/client/extension.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,8 @@ export function activate(context: ExtensionContext) {
7373
);
7474

7575
// The server bridge is implemented in .NET
76-
const serverModule = context.asAbsolutePath(path.join('devskimBinaries', 'Microsoft.DevSkim.LanguageServer.dll'));
76+
const serverModule = vscode.Uri.joinPath(context.extensionUri, 'devskimBinaries', 'Microsoft.DevSkim.LanguageServer.dll');
77+
7778
resolveDotNetPath().then((dotNetPath) =>
7879
{
7980
if (dotNetPath == undefined || dotNetPath == null)
@@ -83,17 +84,17 @@ export function activate(context: ExtensionContext) {
8384
}
8485
else
8586
{
86-
const workPath = path.dirname(serverModule);
87+
const workPath = path.dirname(serverModule.fsPath);
8788
const serverOptions: ServerOptions = {
8889
run: {
8990
command: dotNetPath,
90-
args: [serverModule],
91+
args: [serverModule.fsPath],
9192
options: {cwd: workPath},
9293
transport: TransportKind.pipe
9394
},
9495
debug: {
9596
command: dotNetPath,
96-
args: [serverModule],
97+
args: [serverModule.fsPath],
9798
options: {cwd: workPath},
9899
transport: TransportKind.pipe
99100
}

DevSkim-VSCode-Plugin/client/tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
"./common/notificationNames.ts",
2222
"./common/selectors.ts",
2323
"./common/fileVersion.ts",
24-
"devskimFixer.ts",
24+
"devSkimFixer.ts",
2525
"extension.ts"
2626
]
2727
}

0 commit comments

Comments
 (0)